github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 13:21:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): dedupe update runner stable command mocks

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-15 15:27:47 +00:00
parent 0f4036b0f6
commit 88cac5985e
1 changed files with 78 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

163
src/infra/update-runner.test.ts
View File

@@ -47,6 +47,64 @@ describe("runGatewayUpdate", () => {
// Shared fixtureRoot cleaned up in afterAll. // Shared fixtureRoot cleaned up in afterAll.
}); });
function createStableTagRunner(params: {
stableTag: string;
uiIndexPath: string;
onDoctor?: () => Promise<void>;
onUiBuild?: (count: number) => Promise<void>;
}) {
const calls: string[] = [];
let uiBuildCount = 0;
const doctorKey = `${process.execPath} ${path.join(tempDir, "openclaw.mjs")} doctor --non-interactive`;
const runCommand = async (argv: string[]) => {
const key = argv.join(" ");
calls.push(key);
if (key === `git -C ${tempDir} rev-parse --show-toplevel`) {
return { stdout: tempDir, stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} rev-parse HEAD`) {
return { stdout: "abc123", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} status --porcelain -- :!dist/control-ui/`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} fetch --all --prune --tags`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} tag --list v* --sort=-v:refname`) {
return { stdout: `${params.stableTag}\n`, stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} checkout --detach ${params.stableTag}`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm install") {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm build") {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm ui:build") {
uiBuildCount += 1;
await params.onUiBuild?.(uiBuildCount);
return { stdout: "", stderr: "", code: 0 };
}
if (key === doctorKey) {
await params.onDoctor?.();
return { stdout: "", stderr: "", code: 0 };
}
return { stdout: "", stderr: "", code: 0 };
};
return {
runCommand,
calls,
doctorKey,
getUiBuildCount: () => uiBuildCount,
};
}
it("skips git update when worktree is dirty", async () => { it("skips git update when worktree is dirty", async () => {
await fs.mkdir(path.join(tempDir, ".git")); await fs.mkdir(path.join(tempDir, ".git"));
await fs.writeFile( await fs.writeFile(
@@ -416,50 +474,17 @@ describe("runGatewayUpdate", () => {
await fs.writeFile(uiIndexPath, "<html></html>", "utf-8"); await fs.writeFile(uiIndexPath, "<html></html>", "utf-8");
const stableTag = "v1.0.1-1"; const stableTag = "v1.0.1-1";
const calls: string[] = []; const { runCommand, calls, doctorKey, getUiBuildCount } = createStableTagRunner({
let uiBuildCount = 0; stableTag,
uiIndexPath,
const runCommand = async (argv: string[]) => { onUiBuild: async (count) => {
const key = argv.join(" ");
calls.push(key);
if (key === `git -C ${tempDir} rev-parse --show-toplevel`) {
return { stdout: tempDir, stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} rev-parse HEAD`) {
return { stdout: "abc123", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} status --porcelain -- :!dist/control-ui/`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} fetch --all --prune --tags`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} tag --list v* --sort=-v:refname`) {
return { stdout: `${stableTag}\n`, stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} checkout --detach ${stableTag}`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm install") {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm build") {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm ui:build") {
uiBuildCount += 1;
await fs.mkdir(path.dirname(uiIndexPath), { recursive: true }); await fs.mkdir(path.dirname(uiIndexPath), { recursive: true });
await fs.writeFile(uiIndexPath, `<html>${uiBuildCount}</html>`, "utf-8"); await fs.writeFile(uiIndexPath, `<html>${count}</html>`, "utf-8");
return { stdout: "", stderr: "", code: 0 }; },
} onDoctor: async () => {
if (
key === `${process.execPath} ${path.join(tempDir, "openclaw.mjs")} doctor --non-interactive`
) {
await fs.rm(path.join(tempDir, "dist", "control-ui"), { recursive: true, force: true }); await fs.rm(path.join(tempDir, "dist", "control-ui"), { recursive: true, force: true });
return { stdout: "", stderr: "", code: 0 }; },
} });
return { stdout: "", stderr: "", code: 0 };
};
const result = await runGatewayUpdate({ const result = await runGatewayUpdate({
cwd: tempDir, cwd: tempDir,
@@ -469,11 +494,9 @@ describe("runGatewayUpdate", () => {
}); });
expect(result.status).toBe("ok"); expect(result.status).toBe("ok");
expect(uiBuildCount).toBe(2); expect(getUiBuildCount()).toBe(2);
expect(await pathExists(uiIndexPath)).toBe(true); expect(await pathExists(uiIndexPath)).toBe(true);
expect(calls).toContain( expect(calls).toContain(doctorKey);
`${process.execPath} ${path.join(tempDir, "openclaw.mjs")} doctor --non-interactive`,
);
}); });
it("fails when UI assets are still missing after post-doctor repair", async () => { it("fails when UI assets are still missing after post-doctor repair", async () => {
@@ -488,49 +511,19 @@ describe("runGatewayUpdate", () => {
await fs.writeFile(uiIndexPath, "<html></html>", "utf-8"); await fs.writeFile(uiIndexPath, "<html></html>", "utf-8");
const stableTag = "v1.0.1-1"; const stableTag = "v1.0.1-1";
let uiBuildCount = 0; const { runCommand } = createStableTagRunner({
const runCommand = async (argv: string[]) => { stableTag,
const key = argv.join(" "); uiIndexPath,
if (key === `git -C ${tempDir} rev-parse --show-toplevel`) { onUiBuild: async (count) => {
return { stdout: tempDir, stderr: "", code: 0 }; if (count === 1) {
}
if (key === `git -C ${tempDir} rev-parse HEAD`) {
return { stdout: "abc123", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} status --porcelain -- :!dist/control-ui/`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} fetch --all --prune --tags`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} tag --list v* --sort=-v:refname`) {
return { stdout: `${stableTag}\n`, stderr: "", code: 0 };
}
if (key === `git -C ${tempDir} checkout --detach ${stableTag}`) {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm install") {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm build") {
return { stdout: "", stderr: "", code: 0 };
}
if (key === "pnpm ui:build") {
uiBuildCount += 1;
if (uiBuildCount === 1) {
await fs.mkdir(path.dirname(uiIndexPath), { recursive: true }); await fs.mkdir(path.dirname(uiIndexPath), { recursive: true });
await fs.writeFile(uiIndexPath, "<html>built</html>", "utf-8"); await fs.writeFile(uiIndexPath, "<html>built</html>", "utf-8");
} }
return { stdout: "", stderr: "", code: 0 }; },
} onDoctor: async () => {
if (
key === `${process.execPath} ${path.join(tempDir, "openclaw.mjs")} doctor --non-interactive`
) {
await fs.rm(path.join(tempDir, "dist", "control-ui"), { recursive: true, force: true }); await fs.rm(path.join(tempDir, "dist", "control-ui"), { recursive: true, force: true });
return { stdout: "", stderr: "", code: 0 }; },
} });
return { stdout: "", stderr: "", code: 0 };
};
const result = await runGatewayUpdate({ const result = await runGatewayUpdate({
cwd: tempDir, cwd: tempDir,