github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 19:38:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): dedupe repeated fixture setup helpers

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-22 20:04:02 +00:00
parent 6ef4eda1f0
commit 8af6d1a186
5 changed files with 131 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

98
src/plugins/uninstall.test.ts
View File

@@ -46,6 +46,24 @@ async function createInstalledNpmPluginFixture(params: {
};
}
type UninstallResult = Awaited<ReturnType<typeof uninstallPlugin>>;
async function runDeleteInstalledNpmPluginFixture(baseDir: string): Promise<{
pluginDir: string;
result: UninstallResult;
}> {
const { pluginId, extensionsDir, pluginDir, config } = await createInstalledNpmPluginFixture({
baseDir,
});
const result = await uninstallPlugin({
config,
pluginId,
deleteFiles: true,
extensionsDir,
});
return { pluginDir, result };
}
function createSinglePluginEntries(pluginId = "my-plugin") {
return {
[pluginId]: { enabled: true },
@@ -61,6 +79,21 @@ function createSinglePluginWithEmptySlotsConfig(): OpenClawConfig {
};
}
function createSingleNpmInstallConfig(installPath: string): OpenClawConfig {
return {
plugins: {
entries: createSinglePluginEntries(),
installs: {
"my-plugin": {
source: "npm",
spec: "my-plugin@1.0.0",
installPath,
},
},
},
};
}
async function createPluginDirFixture(baseDir: string, pluginId = "my-plugin") {
const pluginDir = path.join(baseDir, pluginId);
await fs.mkdir(pluginDir, { recursive: true });
@@ -330,18 +363,9 @@ describe("uninstallPlugin", () => {
});
it("deletes directory when deleteFiles is true", async () => {
const { pluginId, extensionsDir, pluginDir, config } = await createInstalledNpmPluginFixture({
baseDir: tempDir,
});
const { pluginDir, result } = await runDeleteInstalledNpmPluginFixture(tempDir);
try {
const result = await uninstallPlugin({
config,
pluginId,
deleteFiles: true,
extensionsDir,
});
expect(result.ok).toBe(true);
if (result.ok) {
expect(result.actions.directory).toBe(true);
@@ -389,18 +413,7 @@ describe("uninstallPlugin", () => {
it("does not delete directory when deleteFiles is false", async () => {
const pluginDir = await createPluginDirFixture(tempDir);
const config: OpenClawConfig = {
plugins: {
entries: createSinglePluginEntries(),
installs: {
"my-plugin": {
source: "npm",
spec: "my-plugin@1.0.0",
installPath: pluginDir,
},
},
},
};
const config = createSingleNpmInstallConfig(pluginDir);
const result = await uninstallPlugin({
config,
@@ -417,20 +430,7 @@ describe("uninstallPlugin", () => {
});
it("succeeds even if directory does not exist", async () => {
const config: OpenClawConfig = {
plugins: {
entries: {
"my-plugin": { enabled: true },
},
installs: {
"my-plugin": {
source: "npm",
spec: "my-plugin@1.0.0",
installPath: "/nonexistent/path",
},
},
},
};
const config = createSingleNpmInstallConfig("/nonexistent/path");
const result = await uninstallPlugin({
config,
@@ -447,18 +447,9 @@ describe("uninstallPlugin", () => {
});
it("returns a warning when directory deletion fails unexpectedly", async () => {
const { pluginId, extensionsDir, config } = await createInstalledNpmPluginFixture({
baseDir: tempDir,
});
const rmSpy = vi.spyOn(fs, "rm").mockRejectedValueOnce(new Error("permission denied"));
try {
const result = await uninstallPlugin({
config,
pluginId,
deleteFiles: true,
extensionsDir,
});
const { result } = await runDeleteInstalledNpmPluginFixture(tempDir);
expect(result.ok).toBe(true);
if (result.ok) {
@@ -477,20 +468,7 @@ describe("uninstallPlugin", () => {
await fs.mkdir(outsideDir, { recursive: true });
await fs.writeFile(path.join(outsideDir, "index.js"), "// keep me");
const config: OpenClawConfig = {
plugins: {
entries: {
"my-plugin": { enabled: true },
},
installs: {
"my-plugin": {
source: "npm",
spec: "my-plugin@1.0.0",
installPath: outsideDir,
},
},
},
};
const config = createSingleNpmInstallConfig(outsideDir);
const result = await uninstallPlugin({
config,