github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-29 15:15:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(outbound): land #38944 from @Narcooo

Browse Source 
Co-authored-by: Narcooo <Narcooo@users.noreply.github.com>
This commit is contained in:
Peter Steinberger
2026-03-07 18:46:48 +00:00
parent 52e7d4295e
commit 8bd0eb5424
4 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/infra/outbound/channel-target.ts
View File

@@ -6,13 +6,17 @@ export const CHANNEL_TARGET_DESCRIPTION =
export const CHANNEL_TARGETS_DESCRIPTION =
"Recipient/channel targets (same format as --target); accepts ids or names when the directory is available.";
function hasNonEmptyString(value: unknown): value is string {
return typeof value === "string" && value.trim().length > 0;
}
export function applyTargetToParams(params: {
action: string;
args: Record<string, unknown>;
}): void {
const target = typeof params.args.target === "string" ? params.args.target.trim() : "";
const hasLegacyTo = typeof params.args.to === "string";
const hasLegacyChannelId = typeof params.args.channelId === "string";
const hasLegacyTo = hasNonEmptyString(params.args.to);
const hasLegacyChannelId = hasNonEmptyString(params.args.channelId);
const mode =
MESSAGE_ACTION_TARGET_MODE[params.action as keyof typeof MESSAGE_ACTION_TARGET_MODE] ?? "none";

15
src/infra/outbound/message-action-normalization.test.ts
View File

@@ -17,6 +17,21 @@ describe("normalizeMessageActionInput", () => {
expect("channelId" in normalized).toBe(false);
});
it("ignores empty-string legacy target fields when explicit target is present", () => {
const normalized = normalizeMessageActionInput({
action: "send",
args: {
target: "1214056829",
channelId: "",
to: " ",
},
});
expect(normalized.target).toBe("1214056829");
expect(normalized.to).toBe("1214056829");
expect("channelId" in normalized).toBe(false);
});
it("maps legacy target fields into canonical target", () => {
const normalized = normalizeMessageActionInput({
action: "send",

4
src/infra/outbound/message-action-normalization.ts
View File

@@ -19,11 +19,13 @@ export function normalizeMessageActionInput(params: {
const explicitTarget =
typeof normalizedArgs.target === "string" ? normalizedArgs.target.trim() : "";
const hasLegacyTargetFields =
typeof normalizedArgs.to === "string" || typeof normalizedArgs.channelId === "string";
const hasLegacyTarget =
(typeof normalizedArgs.to === "string" && normalizedArgs.to.trim().length > 0) ||
(typeof normalizedArgs.channelId === "string" && normalizedArgs.channelId.trim().length > 0);
if (explicitTarget && hasLegacyTarget) {
if (explicitTarget && hasLegacyTargetFields) {
delete normalizedArgs.to;
delete normalizedArgs.channelId;
}