github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 17:24:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sandbox): make /workspace bind mount read-only when workspaceAccess is not rw

Browse Source 
This ensures that when workspaceAccess is set to 'ro' or 'none', the
sandbox workspace (/workspace inside the container) is mounted as
read-only, matching the documented behavior.

Previously, the condition was:
  workspaceAccess === 'ro' && workspaceDir === agentWorkspaceDir

This was always false in 'ro' mode because workspaceDir equals
sandboxWorkspaceDir, not agentWorkspaceDir.

Now the logic is simplified:
  - 'rw': /workspace is writable
  - 'ro': /workspace is read-only
  - 'none': /workspace is read-only
This commit is contained in:
Evan
2026-03-02 21:55:58 +00:00
committed by Peter Steinberger
parent 905c3357eb
commit 903e4dff35
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/agents/sandbox/docker.ts
View File

@@ -452,8 +452,7 @@ async function createSandboxContainer(params: {
bindSourceRoots: [workspaceDir, params.agentWorkspaceDir], bindSourceRoots: [workspaceDir, params.agentWorkspaceDir],
}); });
args.push("--workdir", cfg.workdir); args.push("--workdir", cfg.workdir);
const mainMountSuffix = const mainMountSuffix = params.workspaceAccess === "rw" ? "" : ":ro";
params.workspaceAccess === "ro" && workspaceDir === params.agentWorkspaceDir ? ":ro" : "";
args.push("-v", `${workspaceDir}:${cfg.workdir}${mainMountSuffix}`); args.push("-v", `${workspaceDir}:${cfg.workdir}${mainMountSuffix}`);
if (params.workspaceAccess !== "none" && workspaceDir !== params.agentWorkspaceDir) { if (params.workspaceAccess !== "none" && workspaceDir !== params.agentWorkspaceDir) {
const agentMountSuffix = params.workspaceAccess === "ro" ? ":ro" : ""; const agentMountSuffix = params.workspaceAccess === "ro" ? ":ro" : "";