mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-07 18:31:26 +00:00
fix(sessions): allow cross-agent session file paths in multi-agent setups
When OPENCLAW_STATE_DIR changes between session creation and resolution (e.g., after reinstall or config change), absolute session file paths pointing to other agents' sessions directories were rejected even though they structurally match the valid .../agents/<agentId>/sessions/... pattern. The existing fallback logic in resolvePathWithinSessionsDir extracts the agent ID from the path and tries to resolve it via the current env's state directory. When those directories differ, the containment check fails. Now, if the path structurally matches the agent sessions pattern (validated by extractAgentIdFromAbsoluteSessionPath), we accept it directly as a final fallback. Fixes #15410, Fixes #15565, Fixes #15468
This commit is contained in:
committed by
Peter Steinberger
parent
e20b87f1ba
commit
90774c098a
@@ -469,6 +469,62 @@ describe("sessions", () => {
|
||||
}
|
||||
});
|
||||
|
||||
it("resolves cross-agent absolute sessionFile paths", () => {
|
||||
const prev = process.env.OPENCLAW_STATE_DIR;
|
||||
process.env.OPENCLAW_STATE_DIR = "/home/user/.openclaw";
|
||||
try {
|
||||
// Agent bot1 resolves a sessionFile that belongs to agent bot2
|
||||
const sessionFile = resolveSessionFilePath(
|
||||
"sess-1",
|
||||
{ sessionFile: "/home/user/.openclaw/agents/bot2/sessions/sess-1.jsonl" },
|
||||
{ agentId: "bot1" },
|
||||
);
|
||||
expect(sessionFile).toBe("/home/user/.openclaw/agents/bot2/sessions/sess-1.jsonl");
|
||||
} finally {
|
||||
if (prev === undefined) {
|
||||
delete process.env.OPENCLAW_STATE_DIR;
|
||||
} else {
|
||||
process.env.OPENCLAW_STATE_DIR = prev;
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("resolves cross-agent paths when OPENCLAW_STATE_DIR differs from stored paths", () => {
|
||||
const prev = process.env.OPENCLAW_STATE_DIR;
|
||||
process.env.OPENCLAW_STATE_DIR = "/different/state";
|
||||
try {
|
||||
// sessionFile was created under a different state dir than current env
|
||||
const sessionFile = resolveSessionFilePath(
|
||||
"sess-1",
|
||||
{ sessionFile: "/original/state/agents/bot2/sessions/sess-1.jsonl" },
|
||||
{ agentId: "bot1" },
|
||||
);
|
||||
expect(sessionFile).toBe("/original/state/agents/bot2/sessions/sess-1.jsonl");
|
||||
} finally {
|
||||
if (prev === undefined) {
|
||||
delete process.env.OPENCLAW_STATE_DIR;
|
||||
} else {
|
||||
process.env.OPENCLAW_STATE_DIR = prev;
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("rejects absolute sessionFile paths outside agent sessions directories", () => {
|
||||
const prev = process.env.OPENCLAW_STATE_DIR;
|
||||
process.env.OPENCLAW_STATE_DIR = "/home/user/.openclaw";
|
||||
try {
|
||||
expect(() =>
|
||||
resolveSessionFilePath("sess-1", { sessionFile: "/etc/passwd" }, { agentId: "bot1" }),
|
||||
).toThrow(/within sessions directory/);
|
||||
} finally {
|
||||
if (prev === undefined) {
|
||||
delete process.env.OPENCLAW_STATE_DIR;
|
||||
} else {
|
||||
process.env.OPENCLAW_STATE_DIR = prev;
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("updateSessionStoreEntry merges concurrent patches", async () => {
|
||||
const mainSessionKey = "agent:main:main";
|
||||
const dir = await createCaseDir("updateSessionStoreEntry");
|
||||
|
||||
@@ -152,6 +152,11 @@ function resolvePathWithinSessionsDir(
|
||||
if (resolvedFromPath) {
|
||||
return resolvedFromPath;
|
||||
}
|
||||
// The path structurally matches .../agents/<agentId>/sessions/...
|
||||
// Accept it even if the root directory differs from the current env
|
||||
// (e.g., OPENCLAW_STATE_DIR changed between session creation and resolution).
|
||||
// The structural pattern provides sufficient containment guarantees.
|
||||
return path.resolve(trimmed);
|
||||
}
|
||||
}
|
||||
if (!normalized || normalized.startsWith("..") || path.isAbsolute(normalized)) {
|
||||
|
||||
Reference in New Issue
Block a user