github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-11 01:34:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(gateway): dedupe exec approvals node validation

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-18 23:08:28 +00:00
parent 8e6a7a6343
commit 9a100d520d
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/gateway/server-methods/exec-approvals.ts
View File

@@ -86,6 +86,15 @@ function toExecApprovalsPayload(snapshot: ExecApprovalsSnapshot) {
}; };
} }
function resolveNodeIdOrRespond(nodeId: string, respond: RespondFn): string | null {
const id = nodeId.trim();
if (!id) {
respond(false, undefined, errorShape(ErrorCodes.INVALID_REQUEST, "nodeId required"));
return null;
}
return id;
}
export const execApprovalsHandlers: GatewayRequestHandlers = { export const execApprovalsHandlers: GatewayRequestHandlers = {
"exec.approvals.get": ({ params, respond }) => { "exec.approvals.get": ({ params, respond }) => {
if (!assertValidParams(params, validateExecApprovalsGetParams, "exec.approvals.get", respond)) { if (!assertValidParams(params, validateExecApprovalsGetParams, "exec.approvals.get", respond)) {
@@ -131,9 +140,8 @@ export const execApprovalsHandlers: GatewayRequestHandlers = {
return; return;
} }
const { nodeId } = params as { nodeId: string }; const { nodeId } = params as { nodeId: string };
const id = nodeId.trim(); const id = resolveNodeIdOrRespond(nodeId, respond);
if (!id) { if (!id) {
respond(false, undefined, errorShape(ErrorCodes.INVALID_REQUEST, "nodeId required"));
return; return;
} }
await respondUnavailableOnThrow(respond, async () => { await respondUnavailableOnThrow(respond, async () => {
@@ -165,9 +173,8 @@ export const execApprovalsHandlers: GatewayRequestHandlers = {
file: ExecApprovalsFile; file: ExecApprovalsFile;
baseHash?: string; baseHash?: string;
}; };
const id = nodeId.trim(); const id = resolveNodeIdOrRespond(nodeId, respond);
if (!id) { if (!id) {
respond(false, undefined, errorShape(ErrorCodes.INVALID_REQUEST, "nodeId required"));
return; return;
} }
await respondUnavailableOnThrow(respond, async () => { await respondUnavailableOnThrow(respond, async () => {