github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-09 13:27:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cron): treat missing enabled as true in update() (openclaw#15477) thanks @eternauta1337

Browse Source 
Verified:
- pnpm exec vitest src/cron/service.issue-regressions.test.ts

Co-authored-by: eternauta1337 <550409+eternauta1337@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
This commit is contained in:
Alejandro Santander
2026-02-15 11:52:02 -03:00
committed by GitHub
parent a7b6555195
commit 9a344da298
5 changed files with 125 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/cron/service/timer.ts
View File

@@ -90,7 +90,7 @@ function applyJobResult(
"cron: disabling one-shot job after error",
);
}
} else if (result.status === "error" && job.enabled) {
} else if (result.status === "error" && job.enabled !== false) {
// Apply exponential backoff for errored jobs to prevent retry storms.
const backoff = errorBackoffMs(job.state.consecutiveErrors ?? 1);
const normalNext = computeJobNextRunAtMs(job, result.endedAt);
@@ -107,7 +107,7 @@ function applyJobResult(
},
"cron: applying error backoff",
);
} else if (job.enabled) {
} else if (job.enabled !== false) {
job.state.nextRunAtMs = computeJobNextRunAtMs(job, result.endedAt);
} else {
job.state.nextRunAtMs = undefined;
@@ -129,10 +129,11 @@ export function armTimer(state: CronServiceState) {
const nextAt = nextWakeAtMs(state);
if (!nextAt) {
const jobCount = state.store?.jobs.length ?? 0;
const enabledCount = state.store?.jobs.filter((j) => j.enabled).length ?? 0;
const enabledCount = state.store?.jobs.filter((j) => j.enabled !== false).length ?? 0;
const withNextRun =
state.store?.jobs.filter((j) => j.enabled && typeof j.state.nextRunAtMs === "number")
.length ?? 0;
state.store?.jobs.filter(
(j) => j.enabled !== false && typeof j.state.nextRunAtMs === "number",
).length ?? 0;
state.deps.log.debug(
{ jobCount, enabledCount, withNextRun },
"cron: armTimer skipped - no jobs with nextRunAtMs",
@@ -346,7 +347,7 @@ function findDueJobs(state: CronServiceState): CronJob[] {
if (!j.state) {
j.state = {};
}
if (!j.enabled) {
if (j.enabled === false) {
return false;
}
if (typeof j.state.runningAtMs === "number") {
@@ -370,7 +371,7 @@ export async function runMissedJobs(
if (!j.state) {
j.state = {};
}
if (!j.enabled) {
if (j.enabled === false) {
return false;
}
if (skipJobIds?.has(j.id)) {
@@ -409,7 +410,7 @@ export async function runDueJobs(state: CronServiceState) {
if (!j.state) {
j.state = {};
}
if (!j.enabled) {
if (j.enabled === false) {
return false;
}
if (typeof j.state.runningAtMs === "number") {