refactor(test): dedupe trusted-proxy auth test setup

src/gateway/auth.test.ts

@@ -183,30 +183,44 @@ describe("gateway auth", () => {
 });
 
 describe("trusted-proxy auth", () => {
+  type GatewayConnectInput = Parameters<typeof authorizeGatewayConnect>[0];
   const trustedProxyConfig = {
     userHeader: "x-forwarded-user",
     requiredHeaders: ["x-forwarded-proto"],
     allowUsers: [],
   };
 
-  it("accepts valid request from trusted proxy", async () => {
+  function authorizeTrustedProxy(options?: {
-    const res = await authorizeGatewayConnect({
+    auth?: GatewayConnectInput["auth"];
-      auth: {
+    trustedProxies?: string[];
+    remoteAddress?: string;
+    headers?: Record<string, string>;
+  }) {
+    return authorizeGatewayConnect({
+      auth: options?.auth ?? {
         mode: "trusted-proxy",
         allowTailscale: false,
         trustedProxy: trustedProxyConfig,
       },
       connectAuth: null,
-      trustedProxies: ["10.0.0.1"],
+      trustedProxies: options?.trustedProxies ?? ["10.0.0.1"],
       req: {
-        socket: { remoteAddress: "10.0.0.1" },
+        socket: { remoteAddress: options?.remoteAddress ?? "10.0.0.1" },
         headers: {
           host: "gateway.local",
-          "x-forwarded-user": "nick@example.com",
+          ...options?.headers,
-          "x-forwarded-proto": "https",
         },
       } as never,
     });
+  }
+
+  it("accepts valid request from trusted proxy", async () => {
+    const res = await authorizeTrustedProxy({
+      headers: {
+        "x-forwarded-user": "nick@example.com",
+        "x-forwarded-proto": "https",
+      },
+    });
 
     expect(res.ok).toBe(true);
     expect(res.method).toBe("trusted-proxy");
@@ -214,22 +228,12 @@ describe("trusted-proxy auth", () => {
   });
 
   it("rejects request from untrusted source", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
-      auth: {
+      remoteAddress: "192.168.1.100",
-        mode: "trusted-proxy",
+      headers: {
-        allowTailscale: false,
+        "x-forwarded-user": "attacker@evil.com",
-        trustedProxy: trustedProxyConfig,
+        "x-forwarded-proto": "https",
       },
-      connectAuth: null,
-      trustedProxies: ["10.0.0.1"],
-      req: {
-        socket: { remoteAddress: "192.168.1.100" },
-        headers: {
-          host: "gateway.local",
-          "x-forwarded-user": "attacker@evil.com",
-          "x-forwarded-proto": "https",
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(false);
@@ -237,22 +241,10 @@ describe("trusted-proxy auth", () => {
   });
 
   it("rejects request with missing user header", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
-      auth: {
+      headers: {
-        mode: "trusted-proxy",
+        "x-forwarded-proto": "https",
-        allowTailscale: false,
-        trustedProxy: trustedProxyConfig,
       },
-      connectAuth: null,
-      trustedProxies: ["10.0.0.1"],
-      req: {
-        socket: { remoteAddress: "10.0.0.1" },
-        headers: {
-          host: "gateway.local",
-          "x-forwarded-proto": "https",
-          // missing x-forwarded-user
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(false);
@@ -260,22 +252,10 @@ describe("trusted-proxy auth", () => {
   });
 
   it("rejects request with missing required headers", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
-      auth: {
+      headers: {
-        mode: "trusted-proxy",
+        "x-forwarded-user": "nick@example.com",
-        allowTailscale: false,
-        trustedProxy: trustedProxyConfig,
       },
-      connectAuth: null,
-      trustedProxies: ["10.0.0.1"],
-      req: {
-        socket: { remoteAddress: "10.0.0.1" },
-        headers: {
-          host: "gateway.local",
-          "x-forwarded-user": "nick@example.com",
-          // missing x-forwarded-proto
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(false);
@@ -283,7 +263,7 @@ describe("trusted-proxy auth", () => {
   });
 
   it("rejects user not in allowlist", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
       auth: {
         mode: "trusted-proxy",
         allowTailscale: false,
@@ -292,15 +272,9 @@ describe("trusted-proxy auth", () => {
           allowUsers: ["admin@example.com", "nick@example.com"],
         },
       },
-      connectAuth: null,
+      headers: {
-      trustedProxies: ["10.0.0.1"],
+        "x-forwarded-user": "stranger@other.com",
-      req: {
+      },
-        socket: { remoteAddress: "10.0.0.1" },
-        headers: {
-          host: "gateway.local",
-          "x-forwarded-user": "stranger@other.com",
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(false);
@@ -308,7 +282,7 @@ describe("trusted-proxy auth", () => {
   });
 
   it("accepts user in allowlist", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
       auth: {
         mode: "trusted-proxy",
         allowTailscale: false,
@@ -317,15 +291,9 @@ describe("trusted-proxy auth", () => {
           allowUsers: ["admin@example.com", "nick@example.com"],
         },
       },
-      connectAuth: null,
+      headers: {
-      trustedProxies: ["10.0.0.1"],
+        "x-forwarded-user": "nick@example.com",
-      req: {
+      },
-        socket: { remoteAddress: "10.0.0.1" },
-        headers: {
-          host: "gateway.local",
-          "x-forwarded-user": "nick@example.com",
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(true);
@@ -334,21 +302,11 @@ describe("trusted-proxy auth", () => {
   });
 
   it("rejects when no trustedProxies configured", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
-      auth: {
-        mode: "trusted-proxy",
-        allowTailscale: false,
-        trustedProxy: trustedProxyConfig,
-      },
-      connectAuth: null,
       trustedProxies: [],
-      req: {
+      headers: {
-        socket: { remoteAddress: "10.0.0.1" },
+        "x-forwarded-user": "nick@example.com",
-        headers: {
+      },
-          host: "gateway.local",
-          "x-forwarded-user": "nick@example.com",
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(false);
@@ -356,21 +314,14 @@ describe("trusted-proxy auth", () => {
   });
 
   it("rejects when trustedProxy config missing", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
       auth: {
         mode: "trusted-proxy",
         allowTailscale: false,
-        // trustedProxy missing
       },
-      connectAuth: null,
+      headers: {
-      trustedProxies: ["10.0.0.1"],
+        "x-forwarded-user": "nick@example.com",
-      req: {
+      },
-        socket: { remoteAddress: "10.0.0.1" },
-        headers: {
-          host: "gateway.local",
-          "x-forwarded-user": "nick@example.com",
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(false);
@@ -378,7 +329,7 @@ describe("trusted-proxy auth", () => {
   });
 
   it("supports Pomerium-style headers", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
       auth: {
         mode: "trusted-proxy",
         allowTailscale: false,
@@ -387,16 +338,12 @@ describe("trusted-proxy auth", () => {
           requiredHeaders: ["x-pomerium-jwt-assertion"],
         },
       },
-      connectAuth: null,
       trustedProxies: ["172.17.0.1"],
-      req: {
+      remoteAddress: "172.17.0.1",
-        socket: { remoteAddress: "172.17.0.1" },
+      headers: {
-        headers: {
+        "x-pomerium-claim-email": "nick@example.com",
-          host: "gateway.local",
+        "x-pomerium-jwt-assertion": "eyJ...",
-          "x-pomerium-claim-email": "nick@example.com",
+      },
-          "x-pomerium-jwt-assertion": "eyJ...",
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(true);
@@ -405,7 +352,7 @@ describe("trusted-proxy auth", () => {
   });
 
   it("trims whitespace from user header value", async () => {
-    const res = await authorizeGatewayConnect({
+    const res = await authorizeTrustedProxy({
       auth: {
         mode: "trusted-proxy",
         allowTailscale: false,
@@ -413,15 +360,9 @@ describe("trusted-proxy auth", () => {
           userHeader: "x-forwarded-user",
         },
       },
-      connectAuth: null,
+      headers: {
-      trustedProxies: ["10.0.0.1"],
+        "x-forwarded-user": "  nick@example.com  ",
-      req: {
+      },
-        socket: { remoteAddress: "10.0.0.1" },
-        headers: {
-          host: "gateway.local",
-          "x-forwarded-user": "  nick@example.com  ",
-        },
-      } as never,
     });
 
     expect(res.ok).toBe(true);