telegram: centralize api error logging

src/telegram/bot-native-commands.ts

@@ -17,6 +17,7 @@ import { dispatchReplyWithBufferedBlockDispatcher } from "../auto-reply/reply/pr
 import { finalizeInboundContext } from "../auto-reply/reply/inbound-context.js";
 import { danger, logVerbose } from "../globals.js";
 import { resolveMarkdownTableMode } from "../config/markdown-tables.js";
+import { withTelegramApiErrorLogging } from "./api-logging.js";
 import {
   normalizeTelegramCommandName,
   TELEGRAM_COMMAND_NAME_PATTERN,
@@ -134,11 +135,17 @@ async function resolveTelegramCommandAuth(params: {
   const senderUsername = msg.from?.username ?? "";
 
   if (isGroup && groupConfig?.enabled === false) {
-    await bot.api.sendMessage(chatId, "This group is disabled.");
+    await withTelegramApiErrorLogging({
+      operation: "sendMessage",
+      fn: () => bot.api.sendMessage(chatId, "This group is disabled."),
+    });
     return null;
   }
   if (isGroup && topicConfig?.enabled === false) {
-    await bot.api.sendMessage(chatId, "This topic is disabled.");
+    await withTelegramApiErrorLogging({
+      operation: "sendMessage",
+      fn: () => bot.api.sendMessage(chatId, "This topic is disabled."),
+    });
     return null;
   }
   if (requireAuth && isGroup && hasGroupAllowOverride) {
@@ -150,7 +157,10 @@ async function resolveTelegramCommandAuth(params: {
         senderUsername,
       })
     ) {
-      await bot.api.sendMessage(chatId, "You are not authorized to use this command.");
+      await withTelegramApiErrorLogging({
+        operation: "sendMessage",
+        fn: () => bot.api.sendMessage(chatId, "You are not authorized to use this command."),
+      });
       return null;
     }
   }
@@ -159,7 +169,10 @@ async function resolveTelegramCommandAuth(params: {
     const defaultGroupPolicy = cfg.channels?.defaults?.groupPolicy;
     const groupPolicy = telegramCfg.groupPolicy ?? defaultGroupPolicy ?? "open";
     if (groupPolicy === "disabled") {
-      await bot.api.sendMessage(chatId, "Telegram group commands are disabled.");
+      await withTelegramApiErrorLogging({
+        operation: "sendMessage",
+        fn: () => bot.api.sendMessage(chatId, "Telegram group commands are disabled."),
+      });
       return null;
     }
     if (groupPolicy === "allowlist" && requireAuth) {
@@ -171,13 +184,19 @@ async function resolveTelegramCommandAuth(params: {
           senderUsername,
         })
       ) {
-        await bot.api.sendMessage(chatId, "You are not authorized to use this command.");
+        await withTelegramApiErrorLogging({
+          operation: "sendMessage",
+          fn: () => bot.api.sendMessage(chatId, "You are not authorized to use this command."),
+        });
         return null;
       }
     }
     const groupAllowlist = resolveGroupPolicy(chatId);
     if (groupAllowlist.allowlistEnabled && !groupAllowlist.allowed) {
-      await bot.api.sendMessage(chatId, "This group is not allowed.");
+      await withTelegramApiErrorLogging({
+        operation: "sendMessage",
+        fn: () => bot.api.sendMessage(chatId, "This group is not allowed."),
+      });
       return null;
     }
   }
@@ -197,7 +216,10 @@ async function resolveTelegramCommandAuth(params: {
     modeWhenAccessGroupsOff: "configured",
   });
   if (requireAuth && !commandAuthorized) {
-    await bot.api.sendMessage(chatId, "You are not authorized to use this command.");
+    await withTelegramApiErrorLogging({
+      operation: "sendMessage",
+      fn: () => bot.api.sendMessage(chatId, "You are not authorized to use this command."),
+    });
     return null;
   }
 
@@ -300,9 +322,11 @@ export const registerTelegramNativeCommands = ({
   ];
 
   if (allCommands.length > 0) {
-    bot.api.setMyCommands(allCommands).catch((err) => {
-      runtime.error?.(danger(`telegram setMyCommands failed: ${String(err)}`));
-    });
+    void withTelegramApiErrorLogging({
+      operation: "setMyCommands",
+      runtime,
+      fn: () => bot.api.setMyCommands(allCommands),
+    }).catch(() => {});
 
     if (typeof (bot as unknown as { command?: unknown }).command !== "function") {
       logVerbose("telegram: bot.command unavailable; skipping native handlers");
@@ -376,9 +400,14 @@ export const registerTelegramNativeCommands = ({
               );
             }
             const replyMarkup = buildInlineKeyboard(rows);
-            await bot.api.sendMessage(chatId, title, {
-              ...(replyMarkup ? { reply_markup: replyMarkup } : {}),
-              ...(resolvedThreadId != null ? { message_thread_id: resolvedThreadId } : {}),
+            await withTelegramApiErrorLogging({
+              operation: "sendMessage",
+              runtime,
+              fn: () =>
+                bot.api.sendMessage(chatId, title, {
+                  ...(replyMarkup ? { reply_markup: replyMarkup } : {}),
+                  ...(resolvedThreadId != null ? { message_thread_id: resolvedThreadId } : {}),
+                }),
             });
             return;
           }
@@ -492,7 +521,11 @@ export const registerTelegramNativeCommands = ({
           const commandBody = `/${pluginCommand.command}${rawText ? ` ${rawText}` : ""}`;
           const match = matchPluginCommand(commandBody);
           if (!match) {
-            await bot.api.sendMessage(chatId, "Command not found.");
+            await withTelegramApiErrorLogging({
+              operation: "sendMessage",
+              runtime,
+              fn: () => bot.api.sendMessage(chatId, "Command not found."),
+            });
             return;
           }
           const auth = await resolveTelegramCommandAuth({
@@ -543,8 +576,10 @@ export const registerTelegramNativeCommands = ({
       }
     }
   } else if (nativeDisabledExplicit) {
-    bot.api.setMyCommands([]).catch((err) => {
-      runtime.error?.(danger(`telegram clear commands failed: ${String(err)}`));
-    });
+    void withTelegramApiErrorLogging({
+      operation: "setMyCommands",
+      runtime,
+      fn: () => bot.api.setMyCommands([]),
+    }).catch(() => {});
   }
 };