github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-12 22:12:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cron): split run and delivery status tracking

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-22 20:07:34 +01:00
parent c3bb723673
commit aa4c250eb8
11 changed files with 128 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
src/cron/service.persists-delivered-status.test.ts
View File

@@ -40,7 +40,7 @@ function buildMainSessionSystemEventJob(name: string): CronAddInput {
function createIsolatedCronWithFinishedBarrier(params: {
storePath: string;
delivered?: boolean;
onFinished?: (evt: { jobId: string; delivered?: boolean }) => void;
onFinished?: (evt: { jobId: string; delivered?: boolean; deliveryStatus?: string }) => void;
}) {
const finished = createFinishedBarrier();
const cron = new CronService({
@@ -56,7 +56,11 @@ function createIsolatedCronWithFinishedBarrier(params: {
})),
onEvent: (evt) => {
if (evt.action === "finished") {
params.onFinished?.({ jobId: evt.jobId, delivered: evt.delivered });
params.onFinished?.({
jobId: evt.jobId,
delivered: evt.delivered,
deliveryStatus: evt.deliveryStatus,
});
}
finished.onEvent(evt);
},
@@ -94,7 +98,10 @@ describe("CronService persists delivered status", () => {
});
expect(updated?.state.lastStatus).toBe("ok");
expect(updated?.state.lastRunStatus).toBe("ok");
expect(updated?.state.lastDelivered).toBe(true);
expect(updated?.state.lastDeliveryStatus).toBe("delivered");
expect(updated?.state.lastDeliveryError).toBeUndefined();
cron.stop();
});
@@ -114,12 +121,15 @@ describe("CronService persists delivered status", () => {
});
expect(updated?.state.lastStatus).toBe("ok");
expect(updated?.state.lastRunStatus).toBe("ok");
expect(updated?.state.lastDelivered).toBe(false);
expect(updated?.state.lastDeliveryStatus).toBe("not-delivered");
expect(updated?.state.lastDeliveryError).toBeUndefined();
cron.stop();
});
it("persists lastDelivered=undefined when isolated job does not deliver", async () => {
it("persists not-requested delivery state when delivery is not configured", async () => {
const store = await makeStorePath();
const { cron, finished } = createIsolatedCronWithFinishedBarrier({
storePath: store.storePath,
@@ -133,7 +143,35 @@ describe("CronService persists delivered status", () => {
});
expect(updated?.state.lastStatus).toBe("ok");
expect(updated?.state.lastRunStatus).toBe("ok");
expect(updated?.state.lastDelivered).toBeUndefined();
expect(updated?.state.lastDeliveryStatus).toBe("not-requested");
expect(updated?.state.lastDeliveryError).toBeUndefined();
cron.stop();
});
it("persists unknown delivery state when delivery is requested but the runner omits delivered", async () => {
const store = await makeStorePath();
const { cron, finished } = createIsolatedCronWithFinishedBarrier({
storePath: store.storePath,
});
await cron.start();
const { updated } = await runSingleJobAndReadState({
cron,
finished,
job: {
...buildIsolatedAgentTurnJob("delivery-unknown"),
delivery: { mode: "announce", channel: "telegram", to: "123" },
},
});
expect(updated?.state.lastStatus).toBe("ok");
expect(updated?.state.lastRunStatus).toBe("ok");
expect(updated?.state.lastDelivered).toBeUndefined();
expect(updated?.state.lastDeliveryStatus).toBe("unknown");
expect(updated?.state.lastDeliveryError).toBeUndefined();
cron.stop();
});
@@ -153,7 +191,9 @@ describe("CronService persists delivered status", () => {
});
expect(updated?.state.lastStatus).toBe("ok");
expect(updated?.state.lastRunStatus).toBe("ok");
expect(updated?.state.lastDelivered).toBeUndefined();
expect(updated?.state.lastDeliveryStatus).toBe("not-requested");
expect(enqueueSystemEvent).toHaveBeenCalled();
cron.stop();
@@ -161,7 +201,7 @@ describe("CronService persists delivered status", () => {
it("emits delivered in the finished event", async () => {
const store = await makeStorePath();
let capturedEvent: { jobId: string; delivered?: boolean } | undefined;
let capturedEvent: { jobId: string; delivered?: boolean; deliveryStatus?: string } | undefined;
const { cron, finished } = createIsolatedCronWithFinishedBarrier({
storePath: store.storePath,
delivered: true,
@@ -179,6 +219,7 @@ describe("CronService persists delivered status", () => {
expect(capturedEvent).toBeDefined();
expect(capturedEvent?.delivered).toBe(true);
expect(capturedEvent?.deliveryStatus).toBe("delivered");
cron.stop();
});
});