github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-07 23:01:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: reclassify local helper suites out of agents e2e

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-22 10:53:40 +00:00
parent b98d3330f6
commit adace58505
18 changed files with 0 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

230
src/agents/sandbox-create-args.test.ts Normal file
View File

@@ -0,0 +1,230 @@
import { describe, expect, it } from "vitest";
import { buildSandboxCreateArgs, type SandboxDockerConfig } from "./sandbox.js";
describe("buildSandboxCreateArgs", () => {
function createSandboxConfig(
overrides: Partial<SandboxDockerConfig> = {},
binds?: string[],
): SandboxDockerConfig {
return {
image: "openclaw-sandbox:bookworm-slim",
containerPrefix: "openclaw-sbx-",
workdir: "/workspace",
readOnlyRoot: false,
tmpfs: [],
network: "none",
capDrop: [],
...(binds ? { binds } : {}),
...overrides,
};
}
function expectBuildToThrow(
name: string,
cfg: SandboxDockerConfig,
expectedMessage: RegExp,
): void {
expect(
() =>
buildSandboxCreateArgs({
name,
cfg,
scopeKey: "main",
createdAtMs: 1700000000000,
}),
name,
).toThrow(expectedMessage);
}
it("includes hardening and resource flags", () => {
const cfg: SandboxDockerConfig = {
image: "openclaw-sandbox:bookworm-slim",
containerPrefix: "openclaw-sbx-",
workdir: "/workspace",
readOnlyRoot: true,
tmpfs: ["/tmp"],
network: "none",
user: "1000:1000",
capDrop: ["ALL"],
env: { LANG: "C.UTF-8" },
pidsLimit: 256,
memory: "512m",
memorySwap: 1024,
cpus: 1.5,
ulimits: {
nofile: { soft: 1024, hard: 2048 },
nproc: 128,
core: "0",
},
seccompProfile: "/tmp/seccomp.json",
apparmorProfile: "openclaw-sandbox",
dns: ["1.1.1.1"],
extraHosts: ["internal.service:10.0.0.5"],
};
const args = buildSandboxCreateArgs({
name: "openclaw-sbx-test",
cfg,
scopeKey: "main",
createdAtMs: 1700000000000,
labels: { "openclaw.sandboxBrowser": "1" },
});
expect(args).toEqual(
expect.arrayContaining([
"create",
"--name",
"openclaw-sbx-test",
"--label",
"openclaw.sandbox=1",
"--label",
"openclaw.sessionKey=main",
"--label",
"openclaw.createdAtMs=1700000000000",
"--label",
"openclaw.sandboxBrowser=1",
"--read-only",
"--tmpfs",
"/tmp",
"--network",
"none",
"--user",
"1000:1000",
"--cap-drop",
"ALL",
"--security-opt",
"no-new-privileges",
"--security-opt",
"seccomp=/tmp/seccomp.json",
"--security-opt",
"apparmor=openclaw-sandbox",
"--dns",
"1.1.1.1",
"--add-host",
"internal.service:10.0.0.5",
"--pids-limit",
"256",
"--memory",
"512m",
"--memory-swap",
"1024",
"--cpus",
"1.5",
]),
);
expect(args).toEqual(expect.arrayContaining(["--env", "LANG=C.UTF-8"]));
const ulimitValues: string[] = [];
for (let i = 0; i < args.length; i += 1) {
if (args[i] === "--ulimit") {
const value = args[i + 1];
if (value) {
ulimitValues.push(value);
}
}
}
expect(ulimitValues).toEqual(
expect.arrayContaining(["nofile=1024:2048", "nproc=128", "core=0"]),
);
});
it("emits -v flags for safe custom binds", () => {
const cfg: SandboxDockerConfig = {
image: "openclaw-sandbox:bookworm-slim",
containerPrefix: "openclaw-sbx-",
workdir: "/workspace",
readOnlyRoot: false,
tmpfs: [],
network: "none",
capDrop: [],
binds: ["/home/user/source:/source:rw", "/var/data/myapp:/data:ro"],
};
const args = buildSandboxCreateArgs({
name: "openclaw-sbx-binds",
cfg,
scopeKey: "main",
createdAtMs: 1700000000000,
});
expect(args).toContain("-v");
const vFlags: string[] = [];
for (let i = 0; i < args.length; i++) {
if (args[i] === "-v") {
const value = args[i + 1];
if (value) {
vFlags.push(value);
}
}
}
expect(vFlags).toContain("/home/user/source:/source:rw");
expect(vFlags).toContain("/var/data/myapp:/data:ro");
});
it.each([
{
name: "dangerous Docker socket bind mounts",
containerName: "openclaw-sbx-dangerous",
cfg: createSandboxConfig({}, ["/var/run/docker.sock:/var/run/docker.sock"]),
expected: /blocked path/,
},
{
name: "dangerous parent bind mounts",
containerName: "openclaw-sbx-dangerous-parent",
cfg: createSandboxConfig({}, ["/run:/run"]),
expected: /blocked path/,
},
{
name: "network host mode",
containerName: "openclaw-sbx-host",
cfg: createSandboxConfig({ network: "host" }),
expected: /network mode "host" is blocked/,
},
{
name: "seccomp unconfined",
containerName: "openclaw-sbx-seccomp",
cfg: createSandboxConfig({ seccompProfile: "unconfined" }),
expected: /seccomp profile "unconfined" is blocked/,
},
{
name: "apparmor unconfined",
containerName: "openclaw-sbx-apparmor",
cfg: createSandboxConfig({ apparmorProfile: "unconfined" }),
expected: /apparmor profile "unconfined" is blocked/,
},
])("throws on $name", ({ containerName, cfg, expected }) => {
expectBuildToThrow(containerName, cfg, expected);
});
it("omits -v flags when binds is empty or undefined", () => {
const cfg: SandboxDockerConfig = {
image: "openclaw-sandbox:bookworm-slim",
containerPrefix: "openclaw-sbx-",
workdir: "/workspace",
readOnlyRoot: false,
tmpfs: [],
network: "none",
capDrop: [],
binds: [],
};
const args = buildSandboxCreateArgs({
name: "openclaw-sbx-no-binds",
cfg,
scopeKey: "main",
createdAtMs: 1700000000000,
});
// Count -v flags that are NOT workspace mounts (workspace mounts are internal)
const customVFlags: string[] = [];
for (let i = 0; i < args.length; i++) {
if (args[i] === "-v") {
const value = args[i + 1];
if (value && !value.includes("/workspace")) {
customVFlags.push(value);
}
}
}
expect(customVFlags).toHaveLength(0);
});
});