refactor(test): dedupe doctor legacy migration fixtures

src/commands/doctor.e2e-harness.ts

@@ -92,7 +92,11 @@ export const autoMigrateLegacyStateDir = vi.fn().mockResolvedValue({
   warnings: [],
 }) as unknown as MockFn;
 
-export const detectLegacyStateMigrations = vi.fn().mockResolvedValue({
+function createLegacyStateMigrationDetectionResult(params?: {
+  hasLegacySessions?: boolean;
+  preview?: string[];
+}) {
+  return {
     targetAgentId: "main",
     targetMainKey: "main",
     targetScope: undefined,
@@ -103,7 +107,7 @@ export const detectLegacyStateMigrations = vi.fn().mockResolvedValue({
       legacyStorePath: "/tmp/state/sessions/sessions.json",
       targetDir: "/tmp/state/agents/main/sessions",
       targetStorePath: "/tmp/state/agents/main/sessions/sessions.json",
-    hasLegacy: false,
+      hasLegacy: params?.hasLegacySessions ?? false,
       legacyKeys: [],
     },
     agentDir: {
@@ -121,8 +125,13 @@ export const detectLegacyStateMigrations = vi.fn().mockResolvedValue({
       targetTelegramPath: "/tmp/oauth/telegram-default-allowFrom.json",
       hasLegacyTelegram: false,
     },
-  preview: [],
+    preview: params?.preview ?? [],
-}) as unknown as MockFn;
+  };
+}
+
+export const detectLegacyStateMigrations = vi
+  .fn()
+  .mockResolvedValue(createLegacyStateMigrationDetectionResult()) as unknown as MockFn;
 
 export const runLegacyStateMigrations = vi.fn().mockResolvedValue({
   changes: [],
@@ -312,37 +321,12 @@ export async function arrangeLegacyStateMigrationTest(): Promise<{
 
   detectLegacyStateMigrations.mockClear();
   runLegacyStateMigrations.mockClear();
-  detectLegacyStateMigrations.mockResolvedValueOnce({
+  detectLegacyStateMigrations.mockResolvedValueOnce(
-    targetAgentId: "main",
+    createLegacyStateMigrationDetectionResult({
-    targetMainKey: "main",
+      hasLegacySessions: true,
-    targetScope: undefined,
-    stateDir: "/tmp/state",
-    oauthDir: "/tmp/oauth",
-    sessions: {
-      legacyDir: "/tmp/state/sessions",
-      legacyStorePath: "/tmp/state/sessions/sessions.json",
-      targetDir: "/tmp/state/agents/main/sessions",
-      targetStorePath: "/tmp/state/agents/main/sessions/sessions.json",
-      hasLegacy: true,
-      legacyKeys: [],
-    },
-    agentDir: {
-      legacyDir: "/tmp/state/agent",
-      targetDir: "/tmp/state/agents/main/agent",
-      hasLegacy: false,
-    },
-    whatsappAuth: {
-      legacyDir: "/tmp/oauth",
-      targetDir: "/tmp/oauth/whatsapp/default",
-      hasLegacy: false,
-    },
-    pairingAllowFrom: {
-      legacyTelegramPath: "/tmp/oauth/telegram-allowFrom.json",
-      targetTelegramPath: "/tmp/oauth/telegram-default-allowFrom.json",
-      hasLegacyTelegram: false,
-    },
       preview: ["- Legacy sessions detected"],
-  });
+    }),
+  );
   runLegacyStateMigrations.mockResolvedValueOnce({
     changes: ["migrated"],
     warnings: [],