perf(test): dedupe slow discord monitor cases

src/discord/monitor.tool-result.sends-status-replies-responseprefix.test.ts

@@ -8,11 +8,13 @@ import {
   updateLastRouteMock,
   upsertPairingRequestMock,
 } from "./monitor.tool-result.test-harness.js";
+import { createDiscordMessageHandler } from "./monitor/message-handler.js";
+import { __resetDiscordChannelInfoCacheForTest } from "./monitor/message-utils.js";
 
 type Config = ReturnType<typeof import("../config/config.js").loadConfig>;
 
 beforeEach(() => {
-  vi.resetModules();
+  __resetDiscordChannelInfoCacheForTest();
   sendMock.mockReset().mockResolvedValue(undefined);
   updateLastRouteMock.mockReset();
   dispatchMock.mockReset().mockImplementation(async ({ dispatcher }) => {
@@ -49,7 +51,6 @@ const CATEGORY_GUILD_CFG = {
 } satisfies Config;
 
 async function createDmHandler(opts: { cfg: Config; runtimeError?: (err: unknown) => void }) {
-  const { createDiscordMessageHandler } = await import("./monitor.js");
   return createDiscordMessageHandler({
     cfg: opts.cfg,
     discordConfig: opts.cfg.channels?.discord,
@@ -73,19 +74,16 @@ async function createDmHandler(opts: { cfg: Config; runtimeError?: (err: unknown
   });
 }
 
-function createDmClient(fetchChannel?: ReturnType<typeof vi.fn>) {
-  const resolvedFetchChannel =
-    fetchChannel ??
-    vi.fn().mockResolvedValue({
+function createDmClient() {
+  return {
+    fetchChannel: vi.fn().mockResolvedValue({
       type: ChannelType.DM,
       name: "dm",
-    });
-
-  return { fetchChannel: resolvedFetchChannel } as unknown as Client;
+    }),
+  } as unknown as Client;
 }
 
 async function createCategoryGuildHandler() {
-  const { createDiscordMessageHandler } = await import("./monitor.js");
   return createDiscordMessageHandler({
     cfg: CATEGORY_GUILD_CFG,
     discordConfig: CATEGORY_GUILD_CFG.channels?.discord,
@@ -124,108 +122,6 @@ function createCategoryGuildClient() {
 }
 
 describe("discord tool result dispatch", () => {
-  it("caches channel info lookups between messages", async () => {
-    const cfg = {
-      ...BASE_CFG,
-      channels: { discord: { dm: { enabled: true, policy: "open" } } },
-    } as ReturnType<typeof import("../config/config.js").loadConfig>;
-
-    const handler = await createDmHandler({ cfg });
-    const fetchChannel = vi.fn().mockResolvedValue({
-      type: ChannelType.DM,
-      name: "dm",
-    });
-    const client = createDmClient(fetchChannel);
-    const baseMessage = {
-      content: "hello",
-      channelId: "cache-channel-1",
-      timestamp: new Date().toISOString(),
-      type: MessageType.Default,
-      attachments: [],
-      embeds: [],
-      mentionedEveryone: false,
-      mentionedUsers: [],
-      mentionedRoles: [],
-      author: { id: "u-cache", bot: false, username: "Ada" },
-    };
-
-    await handler(
-      {
-        message: { ...baseMessage, id: "m-cache-1" },
-        author: baseMessage.author,
-        guild_id: null,
-      },
-      client,
-    );
-    await handler(
-      {
-        message: { ...baseMessage, id: "m-cache-2" },
-        author: baseMessage.author,
-        guild_id: null,
-      },
-      client,
-    );
-
-    expect(fetchChannel).toHaveBeenCalledTimes(1);
-  });
-
-  it("includes forwarded message snapshots in body", async () => {
-    let capturedBody = "";
-    dispatchMock.mockImplementationOnce(async ({ ctx, dispatcher }) => {
-      capturedBody = ctx.Body ?? "";
-      dispatcher.sendFinalReply({ text: "ok" });
-      return { queuedFinal: true, counts: { final: 1 } };
-    });
-
-    const cfg = {
-      ...BASE_CFG,
-      channels: { discord: { dm: { enabled: true, policy: "open" } } },
-    } as ReturnType<typeof import("../config/config.js").loadConfig>;
-
-    const handler = await createDmHandler({ cfg });
-    const client = createDmClient();
-
-    await handler(
-      {
-        message: {
-          id: "m-forward-1",
-          content: "",
-          channelId: "c-forward-1",
-          timestamp: new Date().toISOString(),
-          type: MessageType.Default,
-          attachments: [],
-          embeds: [],
-          mentionedEveryone: false,
-          mentionedUsers: [],
-          mentionedRoles: [],
-          author: { id: "u1", bot: false, username: "Ada" },
-          rawData: {
-            message_snapshots: [
-              {
-                message: {
-                  content: "forwarded hello",
-                  embeds: [],
-                  attachments: [],
-                  author: {
-                    id: "u2",
-                    username: "Bob",
-                    discriminator: "0",
-                  },
-                },
-              },
-            ],
-          },
-        },
-        author: { id: "u1", bot: false, username: "Ada" },
-        guild_id: null,
-      },
-      client,
-    );
-
-    expect(capturedBody).toContain("[Forwarded message from @Bob]");
-    expect(capturedBody).toContain("forwarded hello");
-  });
-
   it("uses channel id allowlists for non-thread channels with categories", async () => {
     let capturedCtx: { SessionKey?: string } | undefined;
     dispatchMock.mockImplementationOnce(async ({ ctx, dispatcher }) => {