refactor(test): dedupe web monitor inbox test setup

This commit is contained in:
Peter Steinberger
2026-02-14 19:34:53 +00:00
parent c60844931b
commit b8b7a6e0fa
5 changed files with 243 additions and 491 deletions

View File

@@ -1,99 +1,17 @@
import { vi } from "vitest";
vi.mock("../media/store.js", () => ({
saveMediaBuffer: vi.fn().mockResolvedValue({
id: "mid",
path: "/tmp/mid",
size: 1,
contentType: "image/jpeg",
}),
}));
const mockLoadConfig = vi.fn().mockReturnValue({
channels: {
whatsapp: {
// Allow all in tests by default
allowFrom: ["*"],
},
},
messages: {
messagePrefix: undefined,
responsePrefix: undefined,
},
});
const readAllowFromStoreMock = vi.fn().mockResolvedValue([]);
const upsertPairingRequestMock = vi.fn().mockResolvedValue({ code: "PAIRCODE", created: true });
vi.mock("../config/config.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("../config/config.js")>();
return {
...actual,
loadConfig: () => mockLoadConfig(),
};
});
vi.mock("../pairing/pairing-store.js", () => ({
readChannelAllowFromStore: (...args: unknown[]) => readAllowFromStoreMock(...args),
upsertChannelPairingRequest: (...args: unknown[]) => upsertPairingRequestMock(...args),
}));
vi.mock("./session.js", () => {
const { EventEmitter } = require("node:events");
const ev = new EventEmitter();
const sock = {
ev,
ws: { close: vi.fn() },
sendPresenceUpdate: vi.fn().mockResolvedValue(undefined),
sendMessage: vi.fn().mockResolvedValue(undefined),
readMessages: vi.fn().mockResolvedValue(undefined),
updateMediaMessage: vi.fn(),
logger: {},
signalRepository: {
lidMapping: {
getPNForLID: vi.fn().mockResolvedValue(null),
},
},
user: { id: "123@s.whatsapp.net" },
};
return {
createWaSocket: vi.fn().mockResolvedValue(sock),
waitForWaConnection: vi.fn().mockResolvedValue(undefined),
getStatusCode: vi.fn(() => 500),
};
});
const { createWaSocket } = await import("./session.js");
const _getSock = () => (createWaSocket as unknown as () => Promise<ReturnType<typeof mockSock>>)();
import fsSync from "node:fs";
import os from "node:os";
import path from "node:path";
import { afterEach, beforeEach, describe, expect, it } from "vitest";
import { resetLogger, setLoggerOverride } from "../logging.js";
import { monitorWebInbox, resetWebInboundDedupe } from "./inbound.js";
const ACCOUNT_ID = "default";
let authDir: string;
import "./monitor-inbox.test-harness.js";
import { describe, expect, it, vi } from "vitest";
import { monitorWebInbox } from "./inbound.js";
import {
DEFAULT_ACCOUNT_ID,
getAuthDir,
getSock,
installWebMonitorInboxUnitTestHooks,
} from "./monitor-inbox.test-harness.js";
describe("web monitor inbox", () => {
beforeEach(() => {
vi.clearAllMocks();
readAllowFromStoreMock.mockResolvedValue([]);
upsertPairingRequestMock.mockResolvedValue({
code: "PAIRCODE",
created: true,
});
resetWebInboundDedupe();
authDir = fsSync.mkdtempSync(path.join(os.tmpdir(), "openclaw-auth-"));
});
afterEach(() => {
resetLogger();
setLoggerOverride(null);
vi.useRealTimers();
fsSync.rmSync(authDir, { recursive: true, force: true });
});
installWebMonitorInboxUnitTestHooks();
it("streams inbound messages", async () => {
const onMessage = vi.fn(async (msg) => {
@@ -104,10 +22,10 @@ describe("web monitor inbox", () => {
const listener = await monitorWebInbox({
verbose: false,
onMessage,
accountId: ACCOUNT_ID,
authDir,
accountId: DEFAULT_ACCOUNT_ID,
authDir: getAuthDir(),
});
const sock = await createWaSocket();
const sock = getSock();
expect(sock.sendPresenceUpdate).toHaveBeenCalledWith("available");
const upsert = {
type: "notify",
@@ -152,10 +70,10 @@ describe("web monitor inbox", () => {
const listener = await monitorWebInbox({
verbose: false,
onMessage,
accountId: ACCOUNT_ID,
authDir,
accountId: DEFAULT_ACCOUNT_ID,
authDir: getAuthDir(),
});
const sock = await createWaSocket();
const sock = getSock();
const upsert = {
type: "notify",
messages: [
@@ -185,10 +103,10 @@ describe("web monitor inbox", () => {
const listener = await monitorWebInbox({
verbose: false,
onMessage,
accountId: ACCOUNT_ID,
authDir,
accountId: DEFAULT_ACCOUNT_ID,
authDir: getAuthDir(),
});
const sock = await createWaSocket();
const sock = getSock();
const getPNForLID = vi.spyOn(sock.signalRepository.lidMapping, "getPNForLID");
sock.signalRepository.lidMapping.getPNForLID.mockResolvedValueOnce("999:0@s.whatsapp.net");
const upsert = {
@@ -219,17 +137,17 @@ describe("web monitor inbox", () => {
return;
});
fsSync.writeFileSync(
path.join(authDir, "lid-mapping-555_reverse.json"),
path.join(getAuthDir(), "lid-mapping-555_reverse.json"),
JSON.stringify("1555"),
);
const listener = await monitorWebInbox({
verbose: false,
onMessage,
accountId: ACCOUNT_ID,
authDir,
accountId: DEFAULT_ACCOUNT_ID,
authDir: getAuthDir(),
});
const sock = await createWaSocket();
const sock = getSock();
const getPNForLID = vi.spyOn(sock.signalRepository.lidMapping, "getPNForLID");
const upsert = {
type: "notify",
@@ -262,10 +180,10 @@ describe("web monitor inbox", () => {
const listener = await monitorWebInbox({
verbose: false,
onMessage,
accountId: ACCOUNT_ID,
authDir,
accountId: DEFAULT_ACCOUNT_ID,
authDir: getAuthDir(),
});
const sock = await createWaSocket();
const sock = getSock();
const getPNForLID = vi.spyOn(sock.signalRepository.lidMapping, "getPNForLID");
sock.signalRepository.lidMapping.getPNForLID.mockResolvedValueOnce("444:0@s.whatsapp.net");
const upsert = {
@@ -313,10 +231,10 @@ describe("web monitor inbox", () => {
const listener = await monitorWebInbox({
verbose: false,
onMessage,
accountId: ACCOUNT_ID,
authDir,
accountId: DEFAULT_ACCOUNT_ID,
authDir: getAuthDir(),
});
const sock = await createWaSocket();
const sock = getSock();
const upsert = {
type: "notify",
messages: [
@@ -348,7 +266,7 @@ describe("web monitor inbox", () => {
});
const listener = await monitorWebInbox({ verbose: false, onMessage });
const sock = await createWaSocket();
const sock = getSock();
const upsert = {
type: "notify",
messages: [
@@ -393,7 +311,7 @@ describe("web monitor inbox", () => {
});
const listener = await monitorWebInbox({ verbose: false, onMessage });
const sock = await createWaSocket();
const sock = getSock();
const upsert = {
type: "notify",
messages: [