github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 19:28:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(test): fold sender identity checks into channel config suite

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-16 00:31:49 +00:00
parent 2b4ebcb570
commit b97c5d6158
2 changed files with 29 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/channels/channel-config.test.ts
View File

@@ -1,4 +1,5 @@
import { describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import type { MsgContext } from "../auto-reply/templating.js";
import { import {
buildChannelKeyCandidates, buildChannelKeyCandidates,
normalizeChannelSlug, normalizeChannelSlug,
@@ -8,6 +9,7 @@ import {
applyChannelMatchMeta, applyChannelMatchMeta,
resolveChannelMatchConfig, resolveChannelMatchConfig,
} from "./channel-config.js"; } from "./channel-config.js";
import { validateSenderIdentity } from "./sender-identity.js";
describe("buildChannelKeyCandidates", () => { describe("buildChannelKeyCandidates", () => {
it("dedupes and trims keys", () => { it("dedupes and trims keys", () => {
@@ -118,6 +120,33 @@ describe("resolveChannelMatchConfig", () => {
}); });
}); });
describe("validateSenderIdentity", () => {
it("allows direct messages without sender fields", () => {
const ctx: MsgContext = { ChatType: "direct" };
expect(validateSenderIdentity(ctx)).toEqual([]);
});
it("requires some sender identity for non-direct chats", () => {
const ctx: MsgContext = { ChatType: "group" };
expect(validateSenderIdentity(ctx)).toContain(
"missing sender identity (SenderId/SenderName/SenderUsername/SenderE164)",
);
});
it("validates SenderE164 and SenderUsername shape", () => {
const ctx: MsgContext = {
ChatType: "group",
SenderE164: "123",
SenderUsername: "@ada lovelace",
};
expect(validateSenderIdentity(ctx)).toEqual([
"invalid SenderE164: 123",
'SenderUsername should not include "@": @ada lovelace',
"SenderUsername should not include whitespace: @ada lovelace",
]);
});
});
describe("resolveNestedAllowlistDecision", () => { describe("resolveNestedAllowlistDecision", () => {
it("allows when outer allowlist is disabled", () => { it("allows when outer allowlist is disabled", () => {
expect( expect(

30
src/channels/sender-identity.test.ts
View File

@@ -1,30 +0,0 @@
import { describe, expect, it } from "vitest";
import type { MsgContext } from "../auto-reply/templating.js";
import { validateSenderIdentity } from "./sender-identity.js";
describe("validateSenderIdentity", () => {
it("allows direct messages without sender fields", () => {
const ctx: MsgContext = { ChatType: "direct" };
expect(validateSenderIdentity(ctx)).toEqual([]);
});
it("requires some sender identity for non-direct chats", () => {
const ctx: MsgContext = { ChatType: "group" };
expect(validateSenderIdentity(ctx)).toContain(
"missing sender identity (SenderId/SenderName/SenderUsername/SenderE164)",
);
});
it("validates SenderE164 and SenderUsername shape", () => {
const ctx: MsgContext = {
ChatType: "group",
SenderE164: "123",
SenderUsername: "@ada lovelace",
};
expect(validateSenderIdentity(ctx)).toEqual([
"invalid SenderE164: 123",
'SenderUsername should not include "@": @ada lovelace',
"SenderUsername should not include whitespace: @ada lovelace",
]);
});
});