github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-06-02 14:47:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(config): apply uiHints to resolved redaction

Browse Source
This commit is contained in:
Gustavo Madeira Santana
2026-02-15 10:28:11 -05:00
parent 964fabe3b3
commit bb2d219e1f
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/config/redact-snapshot.test.ts
View File

@@ -366,7 +366,9 @@ describe("redactConfigSnapshot", () => {
}); });
const result = redactConfigSnapshot(snapshot, hints); const result = redactConfigSnapshot(snapshot, hints);
const custom = result.config.custom as Record<string, string>; const custom = result.config.custom as Record<string, string>;
const resolved = result.resolved as Record<string, Record<string, string>>;
expect(custom.mySecret).toBe(REDACTED_SENTINEL); expect(custom.mySecret).toBe(REDACTED_SENTINEL);
expect(resolved.custom.mySecret).toBe(REDACTED_SENTINEL);
}); });
it("keeps regex fallback for extension keys not covered by uiHints", () => { it("keeps regex fallback for extension keys not covered by uiHints", () => {
@@ -653,7 +655,9 @@ describe("redactConfigSnapshot", () => {
}); });
const result = redactConfigSnapshot(snapshot, hints); const result = redactConfigSnapshot(snapshot, hints);
const gw = result.config.gateway as Record<string, Record<string, string>>; const gw = result.config.gateway as Record<string, Record<string, string>>;
const resolved = result.resolved as Record<string, Record<string, Record<string, string>>>;
expect(gw.auth.token).toBe("not-actually-secret-value"); expect(gw.auth.token).toBe("not-actually-secret-value");
expect(resolved.gateway.auth.token).toBe("not-actually-secret-value");
}); });
it("does not redact paths absent from uiHints (schema is single source of truth)", () => { it("does not redact paths absent from uiHints (schema is single source of truth)", () => {
@@ -665,7 +669,9 @@ describe("redactConfigSnapshot", () => {
}); });
const result = redactConfigSnapshot(snapshot, hints); const result = redactConfigSnapshot(snapshot, hints);
const gw = result.config.gateway as Record<string, Record<string, string>>; const gw = result.config.gateway as Record<string, Record<string, string>>;
const resolved = result.resolved as Record<string, Record<string, Record<string, string>>>;
expect(gw.auth.password).toBe("not-in-hints-value"); expect(gw.auth.password).toBe("not-in-hints-value");
expect(resolved.gateway.auth.password).toBe("not-in-hints-value");
}); });
it("uses wildcard hints for array items", () => { it("uses wildcard hints for array items", () => {

2
src/config/redact-snapshot.ts
View File

@@ -301,7 +301,7 @@ export function redactConfigSnapshot(
const redactedRaw = snapshot.raw ? redactRawText(snapshot.raw, snapshot.config, uiHints) : null; const redactedRaw = snapshot.raw ? redactRawText(snapshot.raw, snapshot.config, uiHints) : null;
const redactedParsed = snapshot.parsed ? redactObject(snapshot.parsed, uiHints) : snapshot.parsed; const redactedParsed = snapshot.parsed ? redactObject(snapshot.parsed, uiHints) : snapshot.parsed;
// Also redact the resolved config (contains values after ${ENV} substitution) // Also redact the resolved config (contains values after ${ENV} substitution)
const redactedResolved = redactConfigObject(snapshot.resolved); const redactedResolved = redactConfigObject(snapshot.resolved, uiHints);
return { return {
...snapshot, ...snapshot,