github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 23:38:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(fetch): table-drive sync throw cleanup coverage

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 23:26:04 +00:00
parent 833144fd72
commit bcfae0434b
1 changed files with 11 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/infra/fetch.test.ts
View File

@@ -111,21 +111,6 @@ describe("wrapFetchWithAbortSignal", () => {
} }
}); });
it("cleans up listener and rethrows when fetch throws synchronously", () => {
const syncError = new TypeError("sync fetch failure");
const fetchImpl = withFetchPreconnect(
vi.fn(() => {
throw syncError;
}),
);
const wrapped = wrapFetchWithAbortSignal(fetchImpl);
const { fakeSignal, removeEventListener } = createForeignSignalHarness();
expect(() => wrapped("https://example.com", { signal: fakeSignal })).toThrow(syncError);
expect(removeEventListener).toHaveBeenCalledOnce();
});
it("preserves original rejection when listener cleanup throws", async () => { it("preserves original rejection when listener cleanup throws", async () => {
const fetchError = new TypeError("fetch failed"); const fetchError = new TypeError("fetch failed");
const cleanupError = new TypeError("cleanup failed"); const cleanupError = new TypeError("cleanup failed");
@@ -140,9 +125,17 @@ describe("wrapFetchWithAbortSignal", () => {
expect(removeEventListener).toHaveBeenCalledOnce(); expect(removeEventListener).toHaveBeenCalledOnce();
}); });
it("preserves original sync throw when listener cleanup throws", () => { it.each([
{
name: "cleans up listener and rethrows when fetch throws synchronously",
makeSignalHarness: () => createForeignSignalHarness(),
},
{
name: "preserves original sync throw when listener cleanup throws",
makeSignalHarness: () => createThrowingCleanupSignalHarness(new TypeError("cleanup failed")),
},
])("$name", ({ makeSignalHarness }) => {
const syncError = new TypeError("sync fetch failure"); const syncError = new TypeError("sync fetch failure");
const cleanupError = new TypeError("cleanup failed");
const fetchImpl = withFetchPreconnect( const fetchImpl = withFetchPreconnect(
vi.fn(() => { vi.fn(() => {
throw syncError; throw syncError;
@@ -150,7 +143,7 @@ describe("wrapFetchWithAbortSignal", () => {
); );
const wrapped = wrapFetchWithAbortSignal(fetchImpl); const wrapped = wrapFetchWithAbortSignal(fetchImpl);
const { fakeSignal, removeEventListener } = createThrowingCleanupSignalHarness(cleanupError); const { fakeSignal, removeEventListener } = makeSignalHarness();
expect(() => wrapped("https://example.com", { signal: fakeSignal })).toThrow(syncError); expect(() => wrapped("https://example.com", { signal: fakeSignal })).toThrow(syncError);
expect(removeEventListener).toHaveBeenCalledOnce(); expect(removeEventListener).toHaveBeenCalledOnce();