github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 02:32:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(telegram): trim setup resets and table-drive edit fallback cases

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-22 00:01:32 +00:00
parent e0db04a50d
commit c42a7aff37
2 changed files with 121 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

132
src/telegram/send.test.ts
View File

@@ -1271,88 +1271,70 @@ describe("shared send behaviors", () => {
});
describe("editMessageTelegram", () => {
it("handles button payload + parse fallback behavior", async () => {
const cases: Array<{
name: string;
setup: () => {
text: string;
buttons: Parameters<typeof buildInlineKeyboard>[0];
};
expectedCalls: number;
firstExpectNoReplyMarkup?: boolean;
firstExpectReplyMarkup?: Record<string, unknown>;
secondExpectReplyMarkup?: Record<string, unknown>;
}> = [
{
name: "buttons undefined keeps existing keyboard",
setup: () => {
botApi.editMessageText.mockResolvedValue({ message_id: 1, chat: { id: "123" } });
return { text: "hi", buttons: undefined };
},
expectedCalls: 1,
firstExpectNoReplyMarkup: true,
},
{
name: "buttons empty clears keyboard",
setup: () => {
botApi.editMessageText.mockResolvedValue({ message_id: 1, chat: { id: "123" } });
return { text: "hi", buttons: [] };
},
expectedCalls: 1,
firstExpectReplyMarkup: { inline_keyboard: [] },
},
{
name: "parse error fallback preserves cleared keyboard",
setup: () => {
botApi.editMessageText
.mockRejectedValueOnce(new Error("400: Bad Request: can't parse entities"))
.mockResolvedValueOnce({ message_id: 1, chat: { id: "123" } });
return { text: "<bad> html", buttons: [] };
},
expectedCalls: 2,
firstExpectReplyMarkup: { inline_keyboard: [] },
secondExpectReplyMarkup: { inline_keyboard: [] },
},
];
it.each([
{
name: "buttons undefined keeps existing keyboard",
text: "hi",
buttons: undefined as Parameters<typeof buildInlineKeyboard>[0],
expectedCalls: 1,
firstExpectNoReplyMarkup: true,
parseFallback: false,
},
{
name: "buttons empty clears keyboard",
text: "hi",
buttons: [] as Parameters<typeof buildInlineKeyboard>[0],
expectedCalls: 1,
firstExpectReplyMarkup: { inline_keyboard: [] } as Record<string, unknown>,
parseFallback: false,
},
{
name: "parse error fallback preserves cleared keyboard",
text: "<bad> html",
buttons: [] as Parameters<typeof buildInlineKeyboard>[0],
expectedCalls: 2,
firstExpectReplyMarkup: { inline_keyboard: [] } as Record<string, unknown>,
secondExpectReplyMarkup: { inline_keyboard: [] } as Record<string, unknown>,
parseFallback: true,
},
])("$name", async (testCase) => {
if (testCase.parseFallback) {
botApi.editMessageText
.mockRejectedValueOnce(new Error("400: Bad Request: can't parse entities"))
.mockResolvedValueOnce({ message_id: 1, chat: { id: "123" } });
} else {
botApi.editMessageText.mockResolvedValue({ message_id: 1, chat: { id: "123" } });
}
for (const testCase of cases) {
botApi.editMessageText.mockReset();
botCtorSpy.mockReset();
const input = testCase.setup();
await editMessageTelegram("123", 1, testCase.text, {
token: "tok",
cfg: {},
buttons: testCase.buttons ? testCase.buttons.map((row) => [...row]) : testCase.buttons,
});
await editMessageTelegram("123", 1, input.text, {
token: "tok",
cfg: {},
buttons: input.buttons ? input.buttons.map((row) => [...row]) : input.buttons,
});
expect(botCtorSpy, testCase.name).toHaveBeenCalledTimes(1);
expect(botCtorSpy.mock.calls[0]?.[0], testCase.name).toBe("tok");
expect(botApi.editMessageText, testCase.name).toHaveBeenCalledTimes(testCase.expectedCalls);
expect(botCtorSpy, testCase.name).toHaveBeenCalledTimes(1);
expect(botCtorSpy.mock.calls[0]?.[0], testCase.name).toBe("tok");
expect(botApi.editMessageText, testCase.name).toHaveBeenCalledTimes(testCase.expectedCalls);
const firstParams = (botApi.editMessageText.mock.calls[0] ?? [])[3] as Record<string, unknown>;
expect(firstParams, testCase.name).toEqual(expect.objectContaining({ parse_mode: "HTML" }));
if ("firstExpectNoReplyMarkup" in testCase && testCase.firstExpectNoReplyMarkup) {
expect(firstParams, testCase.name).not.toHaveProperty("reply_markup");
}
if ("firstExpectReplyMarkup" in testCase && testCase.firstExpectReplyMarkup) {
expect(firstParams, testCase.name).toEqual(
expect.objectContaining({ reply_markup: testCase.firstExpectReplyMarkup }),
);
}
const firstParams = (botApi.editMessageText.mock.calls[0] ?? [])[3] as Record<
if ("secondExpectReplyMarkup" in testCase && testCase.secondExpectReplyMarkup) {
const secondParams = (botApi.editMessageText.mock.calls[1] ?? [])[3] as Record<
string,
unknown
>;
expect(firstParams, testCase.name).toEqual(expect.objectContaining({ parse_mode: "HTML" }));
if ("firstExpectNoReplyMarkup" in testCase && testCase.firstExpectNoReplyMarkup) {
expect(firstParams, testCase.name).not.toHaveProperty("reply_markup");
}
if ("firstExpectReplyMarkup" in testCase && testCase.firstExpectReplyMarkup) {
expect(firstParams, testCase.name).toEqual(
expect.objectContaining({ reply_markup: testCase.firstExpectReplyMarkup }),
);
}
if ("secondExpectReplyMarkup" in testCase && testCase.secondExpectReplyMarkup) {
const secondParams = (botApi.editMessageText.mock.calls[1] ?? [])[3] as Record<
string,
unknown
>;
expect(secondParams, testCase.name).toEqual(
expect.objectContaining({ reply_markup: testCase.secondExpectReplyMarkup }),
);
}
expect(secondParams, testCase.name).toEqual(
expect.objectContaining({ reply_markup: testCase.secondExpectReplyMarkup }),
);
}
});