github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 03:51:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: chore: Fix types in tests 4/N.

Browse Source
This commit is contained in:
cpojer
2026-02-17 10:51:16 +09:00
parent 1406b28469
commit c49234cbfb
6 changed files with 145 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
src/agents/pi-embedded-utils.e2e.test.ts
View File

@@ -6,9 +6,23 @@ import {
stripDowngradedToolCallText,
} from "./pi-embedded-utils.js";
function makeAssistantMessage(
message: Omit<AssistantMessage, "api" | "provider" | "model" | "usage" | "stopReason"> &
Partial<Pick<AssistantMessage, "api" | "provider" | "model" | "usage" | "stopReason">>,
): AssistantMessage {
return {
api: "responses",
provider: "openai",
model: "gpt-5",
usage: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, totalTokens: 0, cost: 0 },
stopReason: "stop",
...message,
};
}
describe("extractAssistantText", () => {
it("strips Minimax tool invocation XML from text", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -20,14 +34,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("");
});
it("strips multiple tool invocations", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -39,14 +53,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Let me check that.");
});
it("keeps invoke snippets without Minimax markers", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -55,7 +69,7 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe(
@@ -64,7 +78,7 @@ describe("extractAssistantText", () => {
});
it("preserves normal text without tool invocations", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -73,27 +87,27 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("This is a normal response without any tool calls.");
});
it("sanitizes HTTP-ish error text only when stopReason is error", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
stopReason: "error",
errorMessage: "500 Internal Server Error",
content: [{ type: "text", text: "500 Internal Server Error" }],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("HTTP 500: Internal Server Error");
});
it("does not rewrite normal text that references billing plans", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -102,7 +116,7 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe(
@@ -111,7 +125,7 @@ describe("extractAssistantText", () => {
});
it("strips Minimax tool invocations with extra attributes", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -120,14 +134,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Before\nAfter");
});
it("strips minimax tool_call open and close tags", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -136,14 +150,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("StartInnerEnd");
});
it("ignores invoke blocks without minimax markers", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -152,14 +166,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Before<invoke>Keep</invoke>After");
});
it("strips invoke blocks when minimax markers are present elsewhere", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -168,14 +182,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("BeforeAfter");
});
it("strips invoke blocks with nested tags", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -184,14 +198,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("AB");
});
it("strips tool XML mixed with regular content", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -203,14 +217,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("I'll help you with that.\nHere are the results.");
});
it("handles multiple invoke blocks in one message", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -225,14 +239,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("First check.\nSecond check.\nDone.");
});
it("handles stray closing tags without opening tags", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -241,14 +255,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Some text here.More text.");
});
it("returns empty string when message is only tool invocations", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -260,14 +274,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("");
});
it("handles multiple text blocks", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -287,14 +301,14 @@ describe("extractAssistantText", () => {
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("First block.\nThird block.");
});
it("strips downgraded Gemini tool call text representations", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -304,14 +318,14 @@ Arguments: { "command": "git status", "timeout": 120000 }`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("");
});
it("strips multiple downgraded tool calls", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -323,14 +337,14 @@ Arguments: { "command": "ls -la" }`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("");
});
it("strips tool results for downgraded calls", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -340,14 +354,14 @@ Arguments: { "command": "ls -la" }`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("");
});
it("preserves text around downgraded tool calls", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -358,14 +372,14 @@ Arguments: { "action": "act", "request": "click button" }`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Let me check that for you.");
});
it("preserves trailing text after downgraded tool call blocks", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -379,14 +393,14 @@ Back to the user.`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Intro text.\nBack to the user.");
});
it("handles multiple text blocks with tool calls and results", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -409,14 +423,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Here's what I found:\nDone checking.");
});
it("strips thinking tags from text content", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -425,14 +439,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Aquí está tu respuesta.");
});
it("strips thinking tags with attributes", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -441,14 +455,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Visible");
});
it("strips thinking tags without closing tag", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -457,14 +471,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("");
});
it("strips thinking tags with various formats", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -473,14 +487,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("BeforeAfter");
});
it("strips antthinking tags", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -489,14 +503,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("The actual answer.");
});
it("strips final tags while keeping content", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -505,14 +519,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Answer");
});
it("strips thought tags", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -521,14 +535,14 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("Final response.");
});
it("handles nested or multiple thinking blocks", () => {
const msg: AssistantMessage = {
const msg = makeAssistantMessage({
role: "assistant",
content: [
{
@@ -537,7 +551,7 @@ File contents here`,
},
],
timestamp: Date.now(),
};
});
const result = extractAssistantText(msg);
expect(result).toBe("StartMiddleEnd");