github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 19:08:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(cron): dedupe read-only load flow

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-16 01:26:37 +00:00
parent 73a97ee255
commit c95a61aa9d
1 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/cron/service/ops.ts
View File

@@ -14,6 +14,19 @@ import { locked } from "./locked.js";
import { ensureLoaded, persist, warnIfDisabled } from "./store.js"; import { ensureLoaded, persist, warnIfDisabled } from "./store.js";
import { armTimer, emit, executeJob, runMissedJobs, stopTimer, wake } from "./timer.js"; import { armTimer, emit, executeJob, runMissedJobs, stopTimer, wake } from "./timer.js";
async function ensureLoadedForRead(state: CronServiceState) {
await ensureLoaded(state, { skipRecompute: true });
if (!state.store) {
return;
}
// Use the maintenance-only version so that read-only operations never
// advance a past-due nextRunAtMs without executing the job (#16156).
const changed = recomputeNextRunsForMaintenance(state);
if (changed) {
await persist(state);
}
}
export async function start(state: CronServiceState) { export async function start(state: CronServiceState) {
await locked(state, async () => { await locked(state, async () => {
if (!state.deps.cronEnabled) { if (!state.deps.cronEnabled) {
@@ -54,15 +67,7 @@ export function stop(state: CronServiceState) {
export async function status(state: CronServiceState) { export async function status(state: CronServiceState) {
return await locked(state, async () => { return await locked(state, async () => {
await ensureLoaded(state, { skipRecompute: true }); await ensureLoadedForRead(state);
if (state.store) {
// Use the maintenance-only version so that read-only operations never
// advance a past-due nextRunAtMs without executing the job (#16156).
const changed = recomputeNextRunsForMaintenance(state);
if (changed) {
await persist(state);
}
}
return { return {
enabled: state.deps.cronEnabled, enabled: state.deps.cronEnabled,
storePath: state.deps.storePath, storePath: state.deps.storePath,
@@ -74,15 +79,7 @@ export async function status(state: CronServiceState) {
export async function list(state: CronServiceState, opts?: { includeDisabled?: boolean }) { export async function list(state: CronServiceState, opts?: { includeDisabled?: boolean }) {
return await locked(state, async () => { return await locked(state, async () => {
await ensureLoaded(state, { skipRecompute: true }); await ensureLoadedForRead(state);
if (state.store) {
// Use the maintenance-only version so that read-only operations never
// advance a past-due nextRunAtMs without executing the job (#16156).
const changed = recomputeNextRunsForMaintenance(state);
if (changed) {
await persist(state);
}
}
const includeDisabled = opts?.includeDisabled === true; const includeDisabled = opts?.includeDisabled === true;
const jobs = (state.store?.jobs ?? []).filter((j) => includeDisabled || j.enabled); const jobs = (state.store?.jobs ?? []).filter((j) => includeDisabled || j.enabled);
return jobs.toSorted((a, b) => (a.state.nextRunAtMs ?? 0) - (b.state.nextRunAtMs ?? 0)); return jobs.toSorted((a, b) => (a.state.nextRunAtMs ?? 0) - (b.state.nextRunAtMs ?? 0));