github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 11:51:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(shell-env): dedupe repeated login-shell path lookups

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-19 07:49:43 +00:00
parent 9bd2261c0f
commit ca71b5cc51
1 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/infra/shell-env.test.ts
View File

@@ -8,6 +8,23 @@ import {
} from "./shell-env.js"; } from "./shell-env.js";
describe("shell env fallback", () => { describe("shell env fallback", () => {
function getShellPathTwice(params: {
exec: Parameters<typeof getShellPathFromLoginShell>[0]["exec"];
platform: NodeJS.Platform;
}) {
const first = getShellPathFromLoginShell({
env: {} as NodeJS.ProcessEnv,
exec: params.exec,
platform: params.platform,
});
const second = getShellPathFromLoginShell({
env: {} as NodeJS.ProcessEnv,
exec: params.exec,
platform: params.platform,
});
return { first, second };
}
it("is disabled by default", () => { it("is disabled by default", () => {
expect(shouldEnableShellEnvFallback({} as NodeJS.ProcessEnv)).toBe(false); expect(shouldEnableShellEnvFallback({} as NodeJS.ProcessEnv)).toBe(false);
expect(shouldEnableShellEnvFallback({ OPENCLAW_LOAD_SHELL_ENV: "0" })).toBe(false); expect(shouldEnableShellEnvFallback({ OPENCLAW_LOAD_SHELL_ENV: "0" })).toBe(false);
@@ -78,13 +95,7 @@ describe("shell env fallback", () => {
resetShellPathCacheForTests(); resetShellPathCacheForTests();
const exec = vi.fn(() => Buffer.from("PATH=/usr/local/bin:/usr/bin\0HOME=/tmp\0")); const exec = vi.fn(() => Buffer.from("PATH=/usr/local/bin:/usr/bin\0HOME=/tmp\0"));
const first = getShellPathFromLoginShell({ const { first, second } = getShellPathTwice({
env: {} as NodeJS.ProcessEnv,
exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"],
platform: "linux",
});
const second = getShellPathFromLoginShell({
env: {} as NodeJS.ProcessEnv,
exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"], exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"],
platform: "linux", platform: "linux",
}); });
@@ -100,13 +111,7 @@ describe("shell env fallback", () => {
throw new Error("exec failed"); throw new Error("exec failed");
}); });
const first = getShellPathFromLoginShell({ const { first, second } = getShellPathTwice({
env: {} as NodeJS.ProcessEnv,
exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"],
platform: "linux",
});
const second = getShellPathFromLoginShell({
env: {} as NodeJS.ProcessEnv,
exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"], exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"],
platform: "linux", platform: "linux",
}); });
@@ -120,13 +125,7 @@ describe("shell env fallback", () => {
resetShellPathCacheForTests(); resetShellPathCacheForTests();
const exec = vi.fn(() => Buffer.from("PATH=/usr/local/bin:/usr/bin\0HOME=/tmp\0")); const exec = vi.fn(() => Buffer.from("PATH=/usr/local/bin:/usr/bin\0HOME=/tmp\0"));
const first = getShellPathFromLoginShell({ const { first, second } = getShellPathTwice({
env: {} as NodeJS.ProcessEnv,
exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"],
platform: "win32",
});
const second = getShellPathFromLoginShell({
env: {} as NodeJS.ProcessEnv,
exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"], exec: exec as unknown as Parameters<typeof getShellPathFromLoginShell>[0]["exec"],
platform: "win32", platform: "win32",
}); });