github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-05 03:22:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(sandbox): separate bind mounts for browser containers (#16230)

Browse Source 
* feat(sandbox): add separate browser.binds config for browser containers

Allow configuring bind mounts independently for browser containers via
sandbox.browser.binds. When set, browser containers use browser-specific
binds instead of inheriting docker.binds. Falls back to docker.binds
when browser.binds is not configured for backwards compatibility.

Closes #14614

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(sandbox): honor empty browser binds override (#16230) (thanks @seheepeak)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
This commit is contained in:
seheepeak
2026-02-14 23:27:41 +09:00
committed by GitHub
parent 302dafbe1a
commit cb9a5e1cb9
9 changed files with 104 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
src/config/config.sandbox-docker.test.ts
View File

@@ -1,4 +1,5 @@
import { describe, expect, it } from "vitest";
import { resolveSandboxBrowserConfig } from "../agents/sandbox/config.js";
import { validateConfigObject } from "./config.js";
describe("sandbox docker config", () => {
@@ -52,3 +53,83 @@ describe("sandbox docker config", () => {
expect(res.ok).toBe(false);
});
});
describe("sandbox browser binds config", () => {
it("accepts binds array in sandbox.browser config", () => {
const res = validateConfigObject({
agents: {
defaults: {
sandbox: {
browser: {
binds: ["/home/user/.chrome-profile:/data/chrome:rw"],
},
},
},
},
});
expect(res.ok).toBe(true);
if (res.ok) {
expect(res.config.agents?.defaults?.sandbox?.browser?.binds).toEqual([
"/home/user/.chrome-profile:/data/chrome:rw",
]);
}
});
it("rejects non-string values in browser binds array", () => {
const res = validateConfigObject({
agents: {
defaults: {
sandbox: {
browser: {
binds: [123],
},
},
},
},
});
expect(res.ok).toBe(false);
});
it("merges global and agent browser binds", () => {
const resolved = resolveSandboxBrowserConfig({
scope: "agent",
globalBrowser: { binds: ["/global:/global:ro"] },
agentBrowser: { binds: ["/agent:/agent:rw"] },
});
expect(resolved.binds).toEqual(["/global:/global:ro", "/agent:/agent:rw"]);
});
it("treats empty binds as configured (override to none)", () => {
const resolved = resolveSandboxBrowserConfig({
scope: "agent",
globalBrowser: { binds: [] },
agentBrowser: {},
});
expect(resolved.binds).toEqual([]);
});
it("ignores agent browser binds under shared scope", () => {
const resolved = resolveSandboxBrowserConfig({
scope: "shared",
globalBrowser: { binds: ["/global:/global:ro"] },
agentBrowser: { binds: ["/agent:/agent:rw"] },
});
expect(resolved.binds).toEqual(["/global:/global:ro"]);
const resolvedNoGlobal = resolveSandboxBrowserConfig({
scope: "shared",
globalBrowser: {},
agentBrowser: { binds: ["/agent:/agent:rw"] },
});
expect(resolvedNoGlobal.binds).toBeUndefined();
});
it("returns undefined binds when none configured", () => {
const resolved = resolveSandboxBrowserConfig({
scope: "agent",
globalBrowser: {},
agentBrowser: {},
});
expect(resolved.binds).toBeUndefined();
});
});