github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 08:31:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): use env helper in workspace skills prompt gating

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 18:40:59 +00:00
parent 8745964142
commit cf371fde6d
1 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/agents/skills.build-workspace-skills-prompt.prefers-workspace-skills-managed-skills.e2e.test.ts
View File

@@ -2,6 +2,7 @@ import fs from "node:fs/promises";
import os from "node:os"; import os from "node:os";
import path from "node:path"; import path from "node:path";
import { describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import { withEnv } from "../test-utils/env.js";
import { writeSkill } from "./skills.e2e-test-helpers.js"; import { writeSkill } from "./skills.e2e-test-helpers.js";
import { buildWorkspaceSkillsPrompt } from "./skills.js"; import { buildWorkspaceSkillsPrompt } from "./skills.js";
@@ -47,7 +48,6 @@ describe("buildWorkspaceSkillsPrompt", () => {
const workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-")); const workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-"));
const skillsDir = path.join(workspaceDir, "skills"); const skillsDir = path.join(workspaceDir, "skills");
const binDir = path.join(workspaceDir, "bin"); const binDir = path.join(workspaceDir, "bin");
const originalPath = process.env.PATH;
await writeSkill({ await writeSkill({
dir: path.join(skillsDir, "bin-skill"), dir: path.join(skillsDir, "bin-skill"),
@@ -80,22 +80,21 @@ describe("buildWorkspaceSkillsPrompt", () => {
metadata: '{"openclaw":{"requires":{"env":["ENV_KEY"]},"primaryEnv":"ENV_KEY"}}', metadata: '{"openclaw":{"requires":{"env":["ENV_KEY"]},"primaryEnv":"ENV_KEY"}}',
}); });
try { const defaultPrompt = buildWorkspaceSkillsPrompt(workspaceDir, {
const defaultPrompt = buildWorkspaceSkillsPrompt(workspaceDir, { managedSkillsDir: path.join(workspaceDir, ".managed"),
managedSkillsDir: path.join(workspaceDir, ".managed"), });
}); expect(defaultPrompt).toContain("always-skill");
expect(defaultPrompt).toContain("always-skill"); expect(defaultPrompt).toContain("config-skill");
expect(defaultPrompt).toContain("config-skill"); expect(defaultPrompt).not.toContain("bin-skill");
expect(defaultPrompt).not.toContain("bin-skill"); expect(defaultPrompt).not.toContain("anybin-skill");
expect(defaultPrompt).not.toContain("anybin-skill"); expect(defaultPrompt).not.toContain("env-skill");
expect(defaultPrompt).not.toContain("env-skill");
await fs.mkdir(binDir, { recursive: true }); await fs.mkdir(binDir, { recursive: true });
const fakebinPath = path.join(binDir, "fakebin"); const fakebinPath = path.join(binDir, "fakebin");
await fs.writeFile(fakebinPath, "#!/bin/sh\nexit 0\n", "utf-8"); await fs.writeFile(fakebinPath, "#!/bin/sh\nexit 0\n", "utf-8");
await fs.chmod(fakebinPath, 0o755); await fs.chmod(fakebinPath, 0o755);
process.env.PATH = `${binDir}${path.delimiter}${originalPath ?? ""}`;
withEnv({ PATH: `${binDir}${path.delimiter}${process.env.PATH ?? ""}` }, () => {
const gatedPrompt = buildWorkspaceSkillsPrompt(workspaceDir, { const gatedPrompt = buildWorkspaceSkillsPrompt(workspaceDir, {
managedSkillsDir: path.join(workspaceDir, ".managed"), managedSkillsDir: path.join(workspaceDir, ".managed"),
config: { config: {
@@ -108,9 +107,7 @@ describe("buildWorkspaceSkillsPrompt", () => {
expect(gatedPrompt).toContain("env-skill"); expect(gatedPrompt).toContain("env-skill");
expect(gatedPrompt).toContain("always-skill"); expect(gatedPrompt).toContain("always-skill");
expect(gatedPrompt).not.toContain("config-skill"); expect(gatedPrompt).not.toContain("config-skill");
} finally { });
process.env.PATH = originalPath;
}
}); });
it("uses skillKey for config lookups", async () => { it("uses skillKey for config lookups", async () => {
const workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-")); const workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-"));