github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-11 03:24:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(subagents): dedupe focus thread setup fixtures

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 22:32:37 +00:00
parent d476994fb9
commit d069f8b23a
1 changed files with 33 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
src/auto-reply/reply/commands-subagents-focus.test.ts
View File

@@ -131,6 +131,35 @@ function createDiscordCommandParams(commandBody: string) {
return params; return params;
} }
function createStoredBinding(overrides?: Partial<FakeBinding>): FakeBinding {
return {
accountId: "default",
channelId: "parent-1",
threadId: "thread-1",
targetKind: "subagent",
targetSessionKey: "agent:main:subagent:child",
agentId: "main",
label: "child",
boundBy: "user-1",
boundAt: Date.now(),
...overrides,
};
}
async function focusCodexAcpInThread(fake = createFakeThreadBindingManager()) {
hoisted.getThreadBindingManagerMock.mockReturnValue(fake.manager);
hoisted.callGatewayMock.mockImplementation(async (request: unknown) => {
const method = (request as { method?: string }).method;
if (method === "sessions.resolve") {
return { key: "agent:codex-acp:session-1" };
}
return {};
});
const params = createDiscordCommandParams("/focus codex-acp");
const result = await handleSubagentsCommand(params, true);
return { fake, result };
}
describe("/focus, /unfocus, /agents", () => { describe("/focus, /unfocus, /agents", () => {
beforeEach(() => { beforeEach(() => {
resetSubagentRegistryForTests(); resetSubagentRegistryForTests();
@@ -140,18 +169,7 @@ describe("/focus, /unfocus, /agents", () => {
}); });
it("/focus resolves ACP sessions and binds the current Discord thread", async () => { it("/focus resolves ACP sessions and binds the current Discord thread", async () => {
const fake = createFakeThreadBindingManager(); const { fake, result } = await focusCodexAcpInThread();
hoisted.getThreadBindingManagerMock.mockReturnValue(fake.manager);
hoisted.callGatewayMock.mockImplementation(async (request: unknown) => {
const method = (request as { method?: string }).method;
if (method === "sessions.resolve") {
return { key: "agent:codex-acp:session-1" };
}
return {};
});
const params = createDiscordCommandParams("/focus codex-acp");
const result = await handleSubagentsCommand(params, true);
expect(result?.reply?.text).toContain("bound this thread"); expect(result?.reply?.text).toContain("bound this thread");
expect(result?.reply?.text).toContain("(acp)"); expect(result?.reply?.text).toContain("(acp)");
@@ -168,19 +186,7 @@ describe("/focus, /unfocus, /agents", () => {
}); });
it("/unfocus removes an active thread binding for the binding owner", async () => { it("/unfocus removes an active thread binding for the binding owner", async () => {
const fake = createFakeThreadBindingManager([ const fake = createFakeThreadBindingManager([createStoredBinding()]);
{
accountId: "default",
channelId: "parent-1",
threadId: "thread-1",
targetKind: "subagent",
targetSessionKey: "agent:main:subagent:child",
agentId: "main",
label: "child",
boundBy: "user-1",
boundAt: Date.now(),
},
]);
hoisted.getThreadBindingManagerMock.mockReturnValue(fake.manager); hoisted.getThreadBindingManagerMock.mockReturnValue(fake.manager);
const params = createDiscordCommandParams("/unfocus"); const params = createDiscordCommandParams("/unfocus");
@@ -196,30 +202,8 @@ describe("/focus, /unfocus, /agents", () => {
}); });
it("/focus rejects rebinding when the thread is focused by another user", async () => { it("/focus rejects rebinding when the thread is focused by another user", async () => {
const fake = createFakeThreadBindingManager([ const fake = createFakeThreadBindingManager([createStoredBinding({ boundBy: "user-2" })]);
{ const { result } = await focusCodexAcpInThread(fake);
accountId: "default",
channelId: "parent-1",
threadId: "thread-1",
targetKind: "subagent",
targetSessionKey: "agent:main:subagent:child",
agentId: "main",
label: "child",
boundBy: "user-2",
boundAt: Date.now(),
},
]);
hoisted.getThreadBindingManagerMock.mockReturnValue(fake.manager);
hoisted.callGatewayMock.mockImplementation(async (request: unknown) => {
const method = (request as { method?: string }).method;
if (method === "sessions.resolve") {
return { key: "agent:codex-acp:session-1" };
}
return {};
});
const params = createDiscordCommandParams("/focus codex-acp");
const result = await handleSubagentsCommand(params, true);
expect(result?.reply?.text).toContain("Only user-2 can refocus this thread."); expect(result?.reply?.text).toContain("Only user-2 can refocus this thread.");
expect(fake.manager.bindTarget).not.toHaveBeenCalled(); expect(fake.manager.bindTarget).not.toHaveBeenCalled();