github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 11:51:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cron): prevent duplicate fires when multiple jobs trigger simultaneously (#14256)

Browse Source 
The `computeNextRunAtMs` function used `nowSecondMs - 1` as the
reference time for croner's `nextRun()`, which caused it to return the
current second as a valid next-run time. When a job fired at e.g.
11:00:00.500, computing the next run still yielded 11:00:00.000 (same
second, already elapsed), causing the scheduler to immediately re-fire
the job in a tight loop (15-21x observed in the wild).

Fix: use `nowSecondMs` directly (no `-1` lookback) and change the
return guard from `>=` to `>` so next-run is always strictly after
the current second.

Fixes #14164
This commit is contained in:
Xinhua Gu
2026-02-12 05:04:17 +01:00
committed by GitHub
parent b912d3992d
commit dd6047d998
2 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/cron/schedule.ts
View File

@@ -50,16 +50,18 @@ export function computeNextRunAtMs(schedule: CronSchedule, nowMs: number): numbe
catch: false,
});
// Cron operates at second granularity, so floor nowMs to the start of the
// current second. This prevents the lookback from landing inside a matching
// second — if nowMs is e.g. 12:00:00.500 and the pattern fires at second 0,
// a 1ms lookback (12:00:00.499) is still *within* that second, causing
// croner to skip ahead to the next occurrence (e.g. the following day).
// Flooring first ensures the lookback always falls in the *previous* second.
// current second. We ask croner for the next occurrence strictly *after*
// nowSecondMs so that a job whose schedule matches the current second is
// never re-scheduled into the same (already-elapsed) second.
//
// Previous code used `nowSecondMs - 1` which caused croner to return the
// current second as a valid next-run, leading to rapid duplicate fires when
// multiple jobs triggered simultaneously (see #14164).
const nowSecondMs = Math.floor(nowMs / 1000) * 1000;
const next = cron.nextRun(new Date(nowSecondMs - 1));
const next = cron.nextRun(new Date(nowSecondMs));
if (!next) {
return undefined;
}
const nextMs = next.getTime();
return Number.isFinite(nextMs) && nextMs >= nowSecondMs ? nextMs : undefined;
return Number.isFinite(nextMs) && nextMs > nowSecondMs ? nextMs : undefined;
}