github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 19:08:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove monkeypatching from gateway tests

Browse Source 
Replace manual process.env backup/restore with vi.stubEnv():
- server.config-apply.test.ts: Simplified env var pattern
- server.channels.test.ts: Simplified env var pattern
- server.sessions-send.test.ts: Added afterEach cleanup hook, removed try-finally blocks from all 4 tests

Uses proper Vitest isolation instead of manual restoration.
This commit is contained in:
tsavo
2026-01-17 21:32:14 -08:00
parent ad3c12a43a
commit e2bb5eecf3
3 changed files with 100 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/gateway/server.channels.test.ts
View File

@@ -1,4 +1,4 @@
import { describe, expect, test } from "vitest";
import { describe, expect, test, vi } from "vitest";
import {
connectOk,
installGatewayTestHooks,
@@ -12,8 +12,7 @@ installGatewayTestHooks();
describe("gateway server channels", () => {
test("channels.status returns snapshot without probe", async () => {
const prevToken = process.env.TELEGRAM_BOT_TOKEN;
delete process.env.TELEGRAM_BOT_TOKEN;
vi.stubEnv("TELEGRAM_BOT_TOKEN", undefined);
const { server, ws } = await startServerWithClient();
await connectOk(ws);
@@ -43,11 +42,6 @@ describe("gateway server channels", () => {
ws.close();
await server.close();
if (prevToken === undefined) {
delete process.env.TELEGRAM_BOT_TOKEN;
} else {
process.env.TELEGRAM_BOT_TOKEN = prevToken;
}
});
test("channels.logout reports no session when missing", async () => {
@@ -66,8 +60,7 @@ describe("gateway server channels", () => {
});
test("channels.logout clears telegram bot token from config", async () => {
const prevToken = process.env.TELEGRAM_BOT_TOKEN;
delete process.env.TELEGRAM_BOT_TOKEN;
vi.stubEnv("TELEGRAM_BOT_TOKEN", undefined);
const { readConfigFileSnapshot, writeConfigFile } = await loadConfigHelpers();
await writeConfigFile({
channels: {
@@ -98,10 +91,5 @@ describe("gateway server channels", () => {
ws.close();
await server.close();
if (prevToken === undefined) {
delete process.env.TELEGRAM_BOT_TOKEN;
} else {
process.env.TELEGRAM_BOT_TOKEN = prevToken;
}
});
});