github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-19 06:07:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(test): avoid process.env cloning in update-startup suite

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-15 00:05:41 +00:00
parent a0b9ce31bd
commit ed2ae5886d
1 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/infra/update-startup.test.ts
View File

@@ -23,10 +23,15 @@ vi.mock("../version.js", () => ({
})); }));
describe("update-startup", () => { describe("update-startup", () => {
const originalEnv = { ...process.env };
let suiteRoot = ""; let suiteRoot = "";
let suiteCase = 0; let suiteCase = 0;
let tempDir: string; let tempDir: string;
let prevStateDir: string | undefined;
let prevNodeEnv: string | undefined;
let prevVitest: string | undefined;
let hadStateDir = false;
let hadNodeEnv = false;
let hadVitest = false;
let resolveOpenClawPackageRoot: (typeof import("./openclaw-root.js"))["resolveOpenClawPackageRoot"]; let resolveOpenClawPackageRoot: (typeof import("./openclaw-root.js"))["resolveOpenClawPackageRoot"];
let checkUpdateStatus: (typeof import("./update-check.js"))["checkUpdateStatus"]; let checkUpdateStatus: (typeof import("./update-check.js"))["checkUpdateStatus"];
@@ -43,10 +48,19 @@ describe("update-startup", () => {
vi.setSystemTime(new Date("2026-01-17T10:00:00Z")); vi.setSystemTime(new Date("2026-01-17T10:00:00Z"));
tempDir = path.join(suiteRoot, `case-${++suiteCase}`); tempDir = path.join(suiteRoot, `case-${++suiteCase}`);
await fs.mkdir(tempDir, { recursive: true }); await fs.mkdir(tempDir, { recursive: true });
hadStateDir = Object.prototype.hasOwnProperty.call(process.env, "OPENCLAW_STATE_DIR");
prevStateDir = process.env.OPENCLAW_STATE_DIR;
process.env.OPENCLAW_STATE_DIR = tempDir; process.env.OPENCLAW_STATE_DIR = tempDir;
delete process.env.VITEST;
hadNodeEnv = Object.prototype.hasOwnProperty.call(process.env, "NODE_ENV");
prevNodeEnv = process.env.NODE_ENV;
process.env.NODE_ENV = "test"; process.env.NODE_ENV = "test";
// Ensure update checks don't short-circuit in test mode.
hadVitest = Object.prototype.hasOwnProperty.call(process.env, "VITEST");
prevVitest = process.env.VITEST;
delete process.env.VITEST;
// Perf: load mocked modules once (after timers/env are set up). // Perf: load mocked modules once (after timers/env are set up).
if (!loaded) { if (!loaded) {
({ resolveOpenClawPackageRoot } = await import("./openclaw-root.js")); ({ resolveOpenClawPackageRoot } = await import("./openclaw-root.js"));
@@ -58,7 +72,21 @@ describe("update-startup", () => {
afterEach(async () => { afterEach(async () => {
vi.useRealTimers(); vi.useRealTimers();
process.env = { ...originalEnv }; if (hadStateDir) {
process.env.OPENCLAW_STATE_DIR = prevStateDir;
} else {
delete process.env.OPENCLAW_STATE_DIR;
}
if (hadNodeEnv) {
process.env.NODE_ENV = prevNodeEnv;
} else {
delete process.env.NODE_ENV;
}
if (hadVitest) {
process.env.VITEST = prevVitest;
} else {
delete process.env.VITEST;
}
await fs.rm(tempDir, { recursive: true, force: true }); await fs.rm(tempDir, { recursive: true, force: true });
}); });