Merge branch 'main' into vincentkoc-code/slack-block-kit-interactions

src/config/config.talk-validation.test.ts

@@ -8,38 +8,42 @@ describe("talk config validation fail-closed behavior", () => {
     vi.restoreAllMocks();
   });
 
+  async function expectInvalidTalkConfig(config: unknown, messagePattern: RegExp) {
+    await withTempHomeConfig(config, async () => {
+      const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
+
+      let thrown: unknown;
+      try {
+        loadConfig();
+      } catch (error) {
+        thrown = error;
+      }
+
+      expect(thrown).toBeInstanceOf(Error);
+      expect((thrown as { code?: string } | undefined)?.code).toBe("INVALID_CONFIG");
+      expect((thrown as Error).message).toMatch(messagePattern);
+      expect(consoleSpy).toHaveBeenCalled();
+    });
+  }
+
   it.each([
     ["boolean", true],
     ["string", "1500"],
     ["float", 1500.5],
   ])("rejects %s talk.silenceTimeoutMs during config load", async (_label, value) => {
-    await withTempHomeConfig(
+    await expectInvalidTalkConfig(
       {
         agents: { list: [{ id: "main" }] },
         talk: {
           silenceTimeoutMs: value,
         },
       },
-      async () => {
-        const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
-
-        let thrown: unknown;
-        try {
-          loadConfig();
-        } catch (error) {
-          thrown = error;
-        }
-
-        expect(thrown).toBeInstanceOf(Error);
-        expect((thrown as { code?: string } | undefined)?.code).toBe("INVALID_CONFIG");
-        expect((thrown as Error).message).toMatch(/silenceTimeoutMs|talk/i);
-        expect(consoleSpy).toHaveBeenCalled();
-      },
+      /silenceTimeoutMs|talk/i,
     );
   });
 
   it("rejects talk.provider when it does not match talk.providers during config load", async () => {
-    await withTempHomeConfig(
+    await expectInvalidTalkConfig(
       {
         agents: { list: [{ id: "main" }] },
         talk: {
@@ -51,26 +55,12 @@ describe("talk config validation fail-closed behavior", () => {
           },
         },
       },
-      async () => {
-        const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
-
-        let thrown: unknown;
-        try {
-          loadConfig();
-        } catch (error) {
-          thrown = error;
-        }
-
-        expect(thrown).toBeInstanceOf(Error);
-        expect((thrown as { code?: string } | undefined)?.code).toBe("INVALID_CONFIG");
-        expect((thrown as Error).message).toMatch(/talk\.provider|talk\.providers|acme/i);
-        expect(consoleSpy).toHaveBeenCalled();
-      },
+      /talk\.provider|talk\.providers|acme/i,
     );
   });
 
   it("rejects multi-provider talk config without talk.provider during config load", async () => {
-    await withTempHomeConfig(
+    await expectInvalidTalkConfig(
       {
         agents: { list: [{ id: "main" }] },
         talk: {
@@ -84,21 +74,7 @@ describe("talk config validation fail-closed behavior", () => {
           },
         },
       },
-      async () => {
-        const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
-
-        let thrown: unknown;
-        try {
-          loadConfig();
-        } catch (error) {
-          thrown = error;
-        }
-
-        expect(thrown).toBeInstanceOf(Error);
-        expect((thrown as { code?: string } | undefined)?.code).toBe("INVALID_CONFIG");
-        expect((thrown as Error).message).toMatch(/talk\.provider|required/i);
-        expect(consoleSpy).toHaveBeenCalled();
-      },
+      /talk\.provider|required/i,
     );
   });
 });

src/config/paths.test.ts

@@ -1,7 +1,7 @@
 import fs from "node:fs/promises";
-import os from "node:os";
 import path from "node:path";
 import { describe, expect, it } from "vitest";
+import { withTempDir } from "../test-helpers/temp-dir.js";
 import {
   resolveDefaultConfigCandidates,
   resolveConfigPathCandidate,
@@ -37,15 +37,6 @@ describe("oauth paths", () => {
 });
 
 describe("state + config path candidates", () => {
-  async function withTempRoot(prefix: string, run: (root: string) => Promise<void>): Promise<void> {
-    const root = await fs.mkdtemp(path.join(os.tmpdir(), prefix));
-    try {
-      await run(root);
-    } finally {
-      await fs.rm(root, { recursive: true, force: true });
-    }
-  }
-
   function expectOpenClawHomeDefaults(env: NodeJS.ProcessEnv): void {
     const configuredHome = env.OPENCLAW_HOME;
     if (!configuredHome) {
@@ -107,7 +98,7 @@ describe("state + config path candidates", () => {
   });
 
   it("prefers ~/.openclaw when it exists and legacy dir is missing", async () => {
-    await withTempRoot("openclaw-state-", async (root) => {
+    await withTempDir({ prefix: "openclaw-state-" }, async (root) => {
       const newDir = path.join(root, ".openclaw");
       await fs.mkdir(newDir, { recursive: true });
       const resolved = resolveStateDir({} as NodeJS.ProcessEnv, () => root);
@@ -116,7 +107,7 @@ describe("state + config path candidates", () => {
   });
 
   it("falls back to existing legacy state dir when ~/.openclaw is missing", async () => {
-    await withTempRoot("openclaw-state-legacy-", async (root) => {
+    await withTempDir({ prefix: "openclaw-state-legacy-" }, async (root) => {
       const legacyDir = path.join(root, ".clawdbot");
       await fs.mkdir(legacyDir, { recursive: true });
       const resolved = resolveStateDir({} as NodeJS.ProcessEnv, () => root);
@@ -125,7 +116,7 @@ describe("state + config path candidates", () => {
   });
 
   it("CONFIG_PATH prefers existing config when present", async () => {
-    await withTempRoot("openclaw-config-", async (root) => {
+    await withTempDir({ prefix: "openclaw-config-" }, async (root) => {
       const legacyDir = path.join(root, ".openclaw");
       await fs.mkdir(legacyDir, { recursive: true });
       const legacyPath = path.join(legacyDir, "openclaw.json");
@@ -137,7 +128,7 @@ describe("state + config path candidates", () => {
   });
 
   it("respects state dir overrides when config is missing", async () => {
-    await withTempRoot("openclaw-config-override-", async (root) => {
+    await withTempDir({ prefix: "openclaw-config-override-" }, async (root) => {
       const legacyDir = path.join(root, ".openclaw");
       await fs.mkdir(legacyDir, { recursive: true });
       const legacyConfig = path.join(legacyDir, "openclaw.json");

src/config/types.browser.ts

@@ -4,7 +4,7 @@ export type BrowserProfileConfig = {
   /** CDP URL for this profile (use for remote Chrome). */
   cdpUrl?: string;
   /** Profile driver (default: openclaw). */
-  driver?: "openclaw" | "clawd" | "extension";
+  driver?: "openclaw" | "clawd" | "extension" | "existing-session";
   /** If true, never launch a browser for this profile; only attach. Falls back to browser.attachOnly. */
   attachOnly?: boolean;
   /** Profile color (hex). Auto-assigned at creation. */

src/config/zod-schema.ts

@@ -360,7 +360,12 @@ export const OpenClawSchema = z
                 cdpPort: z.number().int().min(1).max(65535).optional(),
                 cdpUrl: z.string().optional(),
                 driver: z
-                  .union([z.literal("openclaw"), z.literal("clawd"), z.literal("extension")])
+                  .union([
+                    z.literal("openclaw"),
+                    z.literal("clawd"),
+                    z.literal("extension"),
+                    z.literal("existing-session"),
+                  ])
                   .optional(),
                 attachOnly: z.boolean().optional(),
                 color: HexColorSchema,