refactor(config): dedupe native command setting resolver

This commit is contained in:
Peter Steinberger
2026-02-18 23:08:52 +00:00
parent 8b257703d8
commit f33ecae0bb
2 changed files with 61 additions and 11 deletions

View File

@@ -21,21 +21,21 @@ export function resolveNativeSkillsEnabled(params: {
providerSetting?: NativeCommandsSetting;
globalSetting?: NativeCommandsSetting;
}): boolean {
const { providerId, providerSetting, globalSetting } = params;
const setting = providerSetting === undefined ? globalSetting : providerSetting;
if (setting === true) {
return true;
}
if (setting === false) {
return false;
}
return resolveAutoDefault(providerId);
return resolveNativeCommandSetting(params);
}
export function resolveNativeCommandsEnabled(params: {
providerId: ChannelId;
providerSetting?: NativeCommandsSetting;
globalSetting?: NativeCommandsSetting;
}): boolean {
return resolveNativeCommandSetting(params);
}
function resolveNativeCommandSetting(params: {
providerId: ChannelId;
providerSetting?: NativeCommandsSetting;
globalSetting?: NativeCommandsSetting;
}): boolean {
const { providerId, providerSetting, globalSetting } = params;
const setting = providerSetting === undefined ? globalSetting : providerSetting;
@@ -45,7 +45,6 @@ export function resolveNativeCommandsEnabled(params: {
if (setting === false) {
return false;
}
// auto or undefined -> heuristic
return resolveAutoDefault(providerId);
}