refactor(agent): dedupe harness and command workflows

src/agents/pi-embedded-runner.sanitize-session-history.e2e.test.ts

@@ -1,11 +1,12 @@
-import type { AgentMessage } from "@mariozechner/pi-agent-core";
-import type { SessionManager } from "@mariozechner/pi-coding-agent";
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import * as helpers from "./pi-embedded-helpers.js";
 import {
-  makeInMemorySessionManager,
-  makeModelSnapshotEntry,
-  makeReasoningAssistantMessages,
+  expectGoogleModelApiFullSanitizeCall,
+  loadSanitizeSessionHistoryWithCleanMocks,
+  makeMockSessionManager,
+  makeSimpleUserMessages,
+  makeSnapshotChangedOpenAIReasoningScenario,
+  sanitizeWithOpenAIResponses,
 } from "./pi-embedded-runner.sanitize-session-history.test-harness.js";
 
 type SanitizeSessionHistory =
@@ -22,45 +23,28 @@ vi.mock("./pi-embedded-helpers.js", async () => {
 });
 
 describe("sanitizeSessionHistory e2e smoke", () => {
-  const mockSessionManager = {
-    getEntries: vi.fn().mockReturnValue([]),
-    appendCustomEntry: vi.fn(),
-  } as unknown as SessionManager;
-  const mockMessages: AgentMessage[] = [{ role: "user", content: "hello" }];
+  const mockSessionManager = makeMockSessionManager();
+  const mockMessages = makeSimpleUserMessages();
 
   beforeEach(async () => {
-    vi.resetAllMocks();
-    vi.mocked(helpers.sanitizeSessionMessagesImages).mockImplementation(async (msgs) => msgs);
-    ({ sanitizeSessionHistory } = await import("./pi-embedded-runner/google.js"));
+    sanitizeSessionHistory = await loadSanitizeSessionHistoryWithCleanMocks();
   });
 
   it("applies full sanitize policy for google model APIs", async () => {
-    vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true);
-
-    await sanitizeSessionHistory({
+    await expectGoogleModelApiFullSanitizeCall({
+      sanitizeSessionHistory,
       messages: mockMessages,
-      modelApi: "google-generative-ai",
-      provider: "google-vertex",
       sessionManager: mockSessionManager,
-      sessionId: "test-session",
     });
-
-    expect(helpers.sanitizeSessionMessagesImages).toHaveBeenCalledWith(
-      mockMessages,
-      "session:history",
-      expect.objectContaining({ sanitizeMode: "full", sanitizeToolCallIds: true }),
-    );
   });
 
   it("keeps images-only sanitize policy without tool-call id rewriting for openai-responses", async () => {
     vi.mocked(helpers.isGoogleModelApi).mockReturnValue(false);
 
-    await sanitizeSessionHistory({
+    await sanitizeWithOpenAIResponses({
+      sanitizeSessionHistory,
       messages: mockMessages,
-      modelApi: "openai-responses",
-      provider: "openai",
       sessionManager: mockSessionManager,
-      sessionId: "test-session",
     });
 
     expect(helpers.sanitizeSessionMessagesImages).toHaveBeenCalledWith(
@@ -74,23 +58,13 @@ describe("sanitizeSessionHistory e2e smoke", () => {
   });
 
   it("downgrades openai reasoning blocks when the model snapshot changed", async () => {
-    const sessionEntries = [
-      makeModelSnapshotEntry({
-        provider: "anthropic",
-        modelApi: "anthropic-messages",
-        modelId: "claude-3-7",
-      }),
-    ];
-    const sessionManager = makeInMemorySessionManager(sessionEntries);
-    const messages = makeReasoningAssistantMessages({ thinkingSignature: "object" });
+    const { sessionManager, messages, modelId } = makeSnapshotChangedOpenAIReasoningScenario();
 
-    const result = await sanitizeSessionHistory({
+    const result = await sanitizeWithOpenAIResponses({
+      sanitizeSessionHistory,
       messages,
-      modelApi: "openai-responses",
-      provider: "openai",
-      modelId: "gpt-5.2-codex",
+      modelId,
       sessionManager,
-      sessionId: "test-session",
     });
 
     expect(result).toEqual([]);