refactor(agent): dedupe harness and command workflows

src/cron/service.test-harness.ts

@@ -3,6 +3,8 @@ import os from "node:os";
 import path from "node:path";
 import { afterAll, afterEach, beforeAll, beforeEach, vi } from "vitest";
 import type { MockFn } from "../test-utils/vitest-mock-fn.js";
+import type { CronEvent } from "./service.js";
+import { CronService } from "./service.js";
 
 export type NoopLogger = {
   debug: MockFn;
@@ -64,3 +66,43 @@ export function installCronTestHooks(options: {
     vi.useRealTimers();
   });
 }
+
+export function createFinishedBarrier() {
+  const resolvers = new Map<string, (evt: CronEvent) => void>();
+  return {
+    waitForOk: (jobId: string) =>
+      new Promise<CronEvent>((resolve) => {
+        resolvers.set(jobId, resolve);
+      }),
+    onEvent: (evt: CronEvent) => {
+      if (evt.action !== "finished" || evt.status !== "ok") {
+        return;
+      }
+      const resolve = resolvers.get(evt.jobId);
+      if (!resolve) {
+        return;
+      }
+      resolvers.delete(evt.jobId);
+      resolve(evt);
+    },
+  };
+}
+
+export function createStartedCronServiceWithFinishedBarrier(params: {
+  storePath: string;
+  logger: ReturnType<typeof createNoopLogger>;
+}) {
+  const enqueueSystemEvent = vi.fn();
+  const requestHeartbeatNow = vi.fn();
+  const finished = createFinishedBarrier();
+  const cron = new CronService({
+    storePath: params.storePath,
+    cronEnabled: true,
+    log: params.logger,
+    enqueueSystemEvent,
+    requestHeartbeatNow,
+    runIsolatedAgentJob: vi.fn(async () => ({ status: "ok" as const })),
+    onEvent: finished.onEvent,
+  });
+  return { cron, enqueueSystemEvent, requestHeartbeatNow, finished };
+}