github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 14:14:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: agent-only announce path, BB message IDs, sender identity, SSRF allowlist (#23970)

Browse Source 
* fix(agents): defer announces until descendant cleanup settles

* fix(bluebubbles): harden message metadata extraction

* feat(contributors): rank by composite score (commits, PRs, LOC, tenure)

* refactor(control-ui): move method guard after path checks to improve request handling

* fix subagent completion announce when only current run is pending

* fix(subagents): keep orchestrator runs active until descendants finish

* fix: prepare PR feedback follow-ups (#23970) (thanks @tyler6204)
This commit is contained in:
Tyler Yust
2026-03-01 22:52:11 -08:00
committed by GitHub
parent cfba64c9db
commit f918b336d1
22 changed files with 814 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/agents/subagent-registry-cleanup.ts
View File

@@ -35,20 +35,27 @@ export function resolveDeferredCleanupDecision(params: {
now: number;
activeDescendantRuns: number;
announceExpiryMs: number;
announceCompletionHardExpiryMs: number;
maxAnnounceRetryCount: number;
deferDescendantDelayMs: number;
resolveAnnounceRetryDelayMs: (retryCount: number) => number;
}): DeferredCleanupDecision {
const endedAgo = resolveEndedAgoMs(params.entry, params.now);
if (params.entry.expectsCompletionMessage === true && params.activeDescendantRuns > 0) {
if (endedAgo > params.announceExpiryMs) {
const isCompletionMessageFlow = params.entry.expectsCompletionMessage === true;
const completionHardExpiryExceeded =
isCompletionMessageFlow && endedAgo > params.announceCompletionHardExpiryMs;
if (isCompletionMessageFlow && params.activeDescendantRuns > 0) {
if (completionHardExpiryExceeded) {
return { kind: "give-up", reason: "expiry" };
}
return { kind: "defer-descendants", delayMs: params.deferDescendantDelayMs };
}
const retryCount = (params.entry.announceRetryCount ?? 0) + 1;
if (retryCount >= params.maxAnnounceRetryCount || endedAgo > params.announceExpiryMs) {
const expiryExceeded = isCompletionMessageFlow
? completionHardExpiryExceeded
: endedAgo > params.announceExpiryMs;
if (retryCount >= params.maxAnnounceRetryCount || expiryExceeded) {
return {
kind: "give-up",
reason: retryCount >= params.maxAnnounceRetryCount ? "retry-limit" : "expiry",