test: move embedded and tool agent suites out of e2e

src/agents/pi-tool-definition-adapter.test.ts

@@ -0,0 +1,49 @@
+import type { AgentTool } from "@mariozechner/pi-agent-core";
+import { Type } from "@sinclair/typebox";
+import { describe, expect, it } from "vitest";
+import { toToolDefinitions } from "./pi-tool-definition-adapter.js";
+
+type ToolExecute = ReturnType<typeof toToolDefinitions>[number]["execute"];
+const extensionContext = {} as Parameters<ToolExecute>[4];
+
+async function executeThrowingTool(name: string, callId: string) {
+  const tool = {
+    name,
+    label: name === "bash" ? "Bash" : "Boom",
+    description: "throws",
+    parameters: Type.Object({}),
+    execute: async () => {
+      throw new Error("nope");
+    },
+  } satisfies AgentTool;
+
+  const defs = toToolDefinitions([tool]);
+  const def = defs[0];
+  if (!def) {
+    throw new Error("missing tool definition");
+  }
+  return await def.execute(callId, {}, undefined, undefined, extensionContext);
+}
+
+describe("pi tool definition adapter", () => {
+  it("wraps tool errors into a tool result", async () => {
+    const result = await executeThrowingTool("boom", "call1");
+
+    expect(result.details).toMatchObject({
+      status: "error",
+      tool: "boom",
+    });
+    expect(result.details).toMatchObject({ error: "nope" });
+    expect(JSON.stringify(result.details)).not.toContain("\n    at ");
+  });
+
+  it("normalizes exec tool aliases in error results", async () => {
+    const result = await executeThrowingTool("bash", "call2");
+
+    expect(result.details).toMatchObject({
+      status: "error",
+      tool: "exec",
+      error: "nope",
+    });
+  });
+});