mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-11 06:04:32 +00:00
Fix tool-call lookup failures when models emit whitespace-padded names by normalizing both transcript history and live streamed embedded-runner tool calls before dispatch. Co-authored-by: wangchunyue <80630709+openperf@users.noreply.github.com> Co-authored-by: Sid <sidqin0410@gmail.com> Co-authored-by: Philipp Spiess <hello@philippspiess.com>
177 lines
5.5 KiB
TypeScript
177 lines
5.5 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
import type { OpenClawConfig } from "../../../config/config.js";
|
|
import {
|
|
resolveAttemptFsWorkspaceOnly,
|
|
resolvePromptBuildHookResult,
|
|
resolvePromptModeForSession,
|
|
wrapStreamFnTrimToolCallNames,
|
|
} from "./attempt.js";
|
|
|
|
describe("resolvePromptBuildHookResult", () => {
|
|
function createLegacyOnlyHookRunner() {
|
|
return {
|
|
hasHooks: vi.fn(
|
|
(hookName: "before_prompt_build" | "before_agent_start") =>
|
|
hookName === "before_agent_start",
|
|
),
|
|
runBeforePromptBuild: vi.fn(async () => undefined),
|
|
runBeforeAgentStart: vi.fn(async () => ({ prependContext: "from-hook" })),
|
|
};
|
|
}
|
|
|
|
it("reuses precomputed legacy before_agent_start result without invoking hook again", async () => {
|
|
const hookRunner = createLegacyOnlyHookRunner();
|
|
const result = await resolvePromptBuildHookResult({
|
|
prompt: "hello",
|
|
messages: [],
|
|
hookCtx: {},
|
|
hookRunner,
|
|
legacyBeforeAgentStartResult: { prependContext: "from-cache", systemPrompt: "legacy-system" },
|
|
});
|
|
|
|
expect(hookRunner.runBeforeAgentStart).not.toHaveBeenCalled();
|
|
expect(result).toEqual({
|
|
prependContext: "from-cache",
|
|
systemPrompt: "legacy-system",
|
|
});
|
|
});
|
|
|
|
it("calls legacy hook when precomputed result is absent", async () => {
|
|
const hookRunner = createLegacyOnlyHookRunner();
|
|
const messages = [{ role: "user", content: "ctx" }];
|
|
const result = await resolvePromptBuildHookResult({
|
|
prompt: "hello",
|
|
messages,
|
|
hookCtx: {},
|
|
hookRunner,
|
|
});
|
|
|
|
expect(hookRunner.runBeforeAgentStart).toHaveBeenCalledTimes(1);
|
|
expect(hookRunner.runBeforeAgentStart).toHaveBeenCalledWith({ prompt: "hello", messages }, {});
|
|
expect(result.prependContext).toBe("from-hook");
|
|
});
|
|
});
|
|
|
|
describe("resolvePromptModeForSession", () => {
|
|
it("uses minimal mode for subagent sessions", () => {
|
|
expect(resolvePromptModeForSession("agent:main:subagent:child")).toBe("minimal");
|
|
});
|
|
|
|
it("uses full mode for cron sessions", () => {
|
|
expect(resolvePromptModeForSession("agent:main:cron:job-1")).toBe("full");
|
|
expect(resolvePromptModeForSession("agent:main:cron:job-1:run:run-abc")).toBe("full");
|
|
});
|
|
});
|
|
|
|
describe("resolveAttemptFsWorkspaceOnly", () => {
|
|
it("uses global tools.fs.workspaceOnly when agent has no override", () => {
|
|
const cfg: OpenClawConfig = {
|
|
tools: {
|
|
fs: { workspaceOnly: true },
|
|
},
|
|
};
|
|
|
|
expect(
|
|
resolveAttemptFsWorkspaceOnly({
|
|
config: cfg,
|
|
sessionAgentId: "main",
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("prefers agent-specific tools.fs.workspaceOnly override", () => {
|
|
const cfg: OpenClawConfig = {
|
|
tools: {
|
|
fs: { workspaceOnly: true },
|
|
},
|
|
agents: {
|
|
list: [
|
|
{
|
|
id: "main",
|
|
tools: {
|
|
fs: { workspaceOnly: false },
|
|
},
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
expect(
|
|
resolveAttemptFsWorkspaceOnly({
|
|
config: cfg,
|
|
sessionAgentId: "main",
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("wrapStreamFnTrimToolCallNames", () => {
|
|
function createFakeStream(params: { events: unknown[]; resultMessage: unknown }): {
|
|
result: () => Promise<unknown>;
|
|
[Symbol.asyncIterator]: () => AsyncIterator<unknown>;
|
|
} {
|
|
return {
|
|
async result() {
|
|
return params.resultMessage;
|
|
},
|
|
[Symbol.asyncIterator]() {
|
|
return (async function* () {
|
|
for (const event of params.events) {
|
|
yield event;
|
|
}
|
|
})();
|
|
},
|
|
};
|
|
}
|
|
|
|
it("trims whitespace from live streamed tool call names and final result message", async () => {
|
|
const partialToolCall = { type: "toolCall", name: " read " };
|
|
const messageToolCall = { type: "toolCall", name: " exec " };
|
|
const finalToolCall = { type: "toolCall", name: " write " };
|
|
const event = {
|
|
type: "toolcall_delta",
|
|
partial: { role: "assistant", content: [partialToolCall] },
|
|
message: { role: "assistant", content: [messageToolCall] },
|
|
};
|
|
const finalMessage = { role: "assistant", content: [finalToolCall] };
|
|
const baseFn = vi.fn(() => createFakeStream({ events: [event], resultMessage: finalMessage }));
|
|
|
|
const wrappedFn = wrapStreamFnTrimToolCallNames(baseFn as never);
|
|
const stream = wrappedFn({} as never, {} as never, {} as never) as Awaited<
|
|
ReturnType<typeof wrappedFn>
|
|
>;
|
|
|
|
const seenEvents: unknown[] = [];
|
|
for await (const item of stream) {
|
|
seenEvents.push(item);
|
|
}
|
|
const result = await stream.result();
|
|
|
|
expect(seenEvents).toHaveLength(1);
|
|
expect(partialToolCall.name).toBe("read");
|
|
expect(messageToolCall.name).toBe("exec");
|
|
expect(finalToolCall.name).toBe("write");
|
|
expect(result).toBe(finalMessage);
|
|
expect(baseFn).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("supports async stream functions that return a promise", async () => {
|
|
const finalToolCall = { type: "toolCall", name: " browser " };
|
|
const finalMessage = { role: "assistant", content: [finalToolCall] };
|
|
const baseFn = vi.fn(async () =>
|
|
createFakeStream({
|
|
events: [],
|
|
resultMessage: finalMessage,
|
|
}),
|
|
);
|
|
|
|
const wrappedFn = wrapStreamFnTrimToolCallNames(baseFn as never);
|
|
const stream = await wrappedFn({} as never, {} as never, {} as never);
|
|
const result = await stream.result();
|
|
|
|
expect(finalToolCall.name).toBe("browser");
|
|
expect(result).toBe(finalMessage);
|
|
expect(baseFn).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|