github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-18 09:07:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(core): dedupe temp dirs in utils tests and cover lid lookup error fallback

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 19:35:57 +00:00
parent c93fc3786c
commit 31a0449f69
1 changed files with 39 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
src/utils.test.ts
View File

@@ -20,6 +20,15 @@ import {
withWhatsAppPrefix,
} from "./utils.js";
function withTempDirSync<T>(prefix: string, run: (dir: string) => T): T {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
try {
return run(dir);
} finally {
fs.rmSync(dir, { recursive: true, force: true });
}
}
describe("normalizePath", () => {
it("adds leading slash when missing", () => {
expect(normalizePath("foo")).toBe("/foo");
@@ -42,10 +51,11 @@ describe("withWhatsAppPrefix", () => {
describe("ensureDir", () => {
it("creates nested directory", async () => {
const tmp = await fs.promises.mkdtemp(path.join(os.tmpdir(), "openclaw-test-"));
const target = path.join(tmp, "nested", "dir");
await ensureDir(target);
expect(fs.existsSync(target)).toBe(true);
await withTempDirSync("openclaw-test-", async (tmp) => {
const target = path.join(tmp, "nested", "dir");
await ensureDir(target);
expect(fs.existsSync(target)).toBe(true);
});
});
});
@@ -97,19 +107,19 @@ describe("jidToE164", () => {
});
it("maps @lid from authDir mapping files", () => {
const authDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-auth-"));
const mappingPath = path.join(authDir, "lid-mapping-456_reverse.json");
fs.writeFileSync(mappingPath, JSON.stringify("5559876"));
expect(jidToE164("456@lid", { authDir })).toBe("+5559876");
fs.rmSync(authDir, { recursive: true, force: true });
withTempDirSync("openclaw-auth-", (authDir) => {
const mappingPath = path.join(authDir, "lid-mapping-456_reverse.json");
fs.writeFileSync(mappingPath, JSON.stringify("5559876"));
expect(jidToE164("456@lid", { authDir })).toBe("+5559876");
});
});
it("maps @hosted.lid from authDir mapping files", () => {
const authDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-auth-"));
const mappingPath = path.join(authDir, "lid-mapping-789_reverse.json");
fs.writeFileSync(mappingPath, JSON.stringify(4440001));
expect(jidToE164("789@hosted.lid", { authDir })).toBe("+4440001");
fs.rmSync(authDir, { recursive: true, force: true });
withTempDirSync("openclaw-auth-", (authDir) => {
const mappingPath = path.join(authDir, "lid-mapping-789_reverse.json");
fs.writeFileSync(mappingPath, JSON.stringify(4440001));
expect(jidToE164("789@hosted.lid", { authDir })).toBe("+4440001");
});
});
it("accepts hosted PN JIDs", () => {
@@ -117,13 +127,13 @@ describe("jidToE164", () => {
});
it("falls back through lidMappingDirs in order", () => {
const first = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-lid-a-"));
const second = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-lid-b-"));
const mappingPath = path.join(second, "lid-mapping-321_reverse.json");
fs.writeFileSync(mappingPath, JSON.stringify("123321"));
expect(jidToE164("321@lid", { lidMappingDirs: [first, second] })).toBe("+123321");
fs.rmSync(first, { recursive: true, force: true });
fs.rmSync(second, { recursive: true, force: true });
withTempDirSync("openclaw-lid-a-", (first) => {
withTempDirSync("openclaw-lid-b-", (second) => {
const mappingPath = path.join(second, "lid-mapping-321_reverse.json");
fs.writeFileSync(mappingPath, JSON.stringify("123321"));
expect(jidToE164("321@lid", { lidMappingDirs: [first, second] })).toBe("+123321");
});
});
});
});
@@ -194,6 +204,14 @@ describe("resolveJidToE164", () => {
await expect(resolveJidToE164("888@s.whatsapp.net", { lidLookup })).resolves.toBe("+888");
expect(lidLookup.getPNForLID).not.toHaveBeenCalled();
});
it("returns null when lidLookup throws", async () => {
const lidLookup = {
getPNForLID: vi.fn().mockRejectedValue(new Error("lookup failed")),
};
await expect(resolveJidToE164("777@lid", { lidLookup })).resolves.toBeNull();
expect(lidLookup.getPNForLID).toHaveBeenCalledWith("777@lid");
});
});
describe("resolveUserPath", () => {