github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-18 05:07:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): share web inbound access control setup

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-14 22:03:33 +00:00
parent dbdcbe03e7
commit 5bead2de85
3 changed files with 67 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/web/inbound/access-control.dm-policy.test.ts
View File

@@ -1,37 +1,18 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import { checkInboundAccessControl } from "./access-control.js";
import { beforeEach, describe, expect, it } from "vitest";
import {
sendMessageMock,
setAccessControlTestConfig,
setupAccessControlTestHarness,
upsertPairingRequestMock,
} from "./access-control.test-harness.js";
const sendMessageMock = vi.fn();
const readAllowFromStoreMock = vi.fn();
const upsertPairingRequestMock = vi.fn();
type CheckInboundAccessControl = typeof import("./access-control.js").checkInboundAccessControl;
let checkInboundAccessControl: CheckInboundAccessControl;
let config: Record<string, unknown> = {};
setupAccessControlTestHarness();
vi.mock("../../config/config.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("../../config/config.js")>();
return {
...actual,
loadConfig: () => config,
};
});
vi.mock("../../pairing/pairing-store.js", () => ({
readChannelAllowFromStore: (...args: unknown[]) => readAllowFromStoreMock(...args),
upsertChannelPairingRequest: (...args: unknown[]) => upsertPairingRequestMock(...args),
}));
beforeEach(() => {
config = {
channels: {
whatsapp: {
dmPolicy: "pairing",
allowFrom: [],
},
},
};
sendMessageMock.mockReset().mockResolvedValue(undefined);
readAllowFromStoreMock.mockReset().mockResolvedValue([]);
upsertPairingRequestMock.mockReset().mockResolvedValue({ code: "PAIRCODE", created: true });
beforeEach(async () => {
({ checkInboundAccessControl } = await import("./access-control.js"));
});
describe("WhatsApp dmPolicy precedence", () => {
@@ -39,7 +20,7 @@ describe("WhatsApp dmPolicy precedence", () => {
// Channel-level says "pairing" but the account-level says "allowlist".
// The account-level override should take precedence, so an unauthorized
// sender should be blocked silently (no pairing reply).
config = {
setAccessControlTestConfig({
channels: {
whatsapp: {
dmPolicy: "pairing",
@@ -51,7 +32,7 @@ describe("WhatsApp dmPolicy precedence", () => {
},
},
},
};
});
const result = await checkInboundAccessControl({
accountId: "work",
@@ -73,7 +54,7 @@ describe("WhatsApp dmPolicy precedence", () => {
it("inherits channel-level dmPolicy when account-level dmPolicy is unset", async () => {
// Account has allowFrom set, but no dmPolicy override. Should inherit the channel default.
// With dmPolicy=allowlist, unauthorized senders are silently blocked.
config = {
setAccessControlTestConfig({
channels: {
whatsapp: {
dmPolicy: "allowlist",
@@ -84,7 +65,7 @@ describe("WhatsApp dmPolicy precedence", () => {
},
},
},
};
});
const result = await checkInboundAccessControl({
accountId: "work",

42
src/web/inbound/access-control.pairing.test.ts
View File

@@ -1,37 +1,17 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import { checkInboundAccessControl } from "./access-control.js";
import { beforeEach, describe, expect, it } from "vitest";
import {
sendMessageMock,
setupAccessControlTestHarness,
upsertPairingRequestMock,
} from "./access-control.test-harness.js";
const sendMessageMock = vi.fn();
const readAllowFromStoreMock = vi.fn();
const upsertPairingRequestMock = vi.fn();
type CheckInboundAccessControl = typeof import("./access-control.js").checkInboundAccessControl;
let checkInboundAccessControl: CheckInboundAccessControl;
let config: Record<string, unknown> = {};
setupAccessControlTestHarness();
vi.mock("../../config/config.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("../../config/config.js")>();
return {
...actual,
loadConfig: () => config,
};
});
vi.mock("../../pairing/pairing-store.js", () => ({
readChannelAllowFromStore: (...args: unknown[]) => readAllowFromStoreMock(...args),
upsertChannelPairingRequest: (...args: unknown[]) => upsertPairingRequestMock(...args),
}));
beforeEach(() => {
config = {
channels: {
whatsapp: {
dmPolicy: "pairing",
allowFrom: [],
},
},
};
sendMessageMock.mockReset().mockResolvedValue(undefined);
readAllowFromStoreMock.mockReset().mockResolvedValue([]);
upsertPairingRequestMock.mockReset().mockResolvedValue({ code: "PAIRCODE", created: true });
beforeEach(async () => {
({ checkInboundAccessControl } = await import("./access-control.js"));
});
describe("checkInboundAccessControl", () => {

40
src/web/inbound/access-control.test-harness.ts Normal file
View File

@@ -0,0 +1,40 @@
import { beforeEach, vi } from "vitest";
export const sendMessageMock = vi.fn();
export const readAllowFromStoreMock = vi.fn();
export const upsertPairingRequestMock = vi.fn();
let config: Record<string, unknown> = {};
export function setAccessControlTestConfig(next: Record<string, unknown>): void {
config = next;
}
export function setupAccessControlTestHarness(): void {
beforeEach(() => {
config = {
channels: {
whatsapp: {
dmPolicy: "pairing",
allowFrom: [],
},
},
};
sendMessageMock.mockReset().mockResolvedValue(undefined);
readAllowFromStoreMock.mockReset().mockResolvedValue([]);
upsertPairingRequestMock.mockReset().mockResolvedValue({ code: "PAIRCODE", created: true });
});
}
vi.mock("../../config/config.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("../../config/config.js")>();
return {
...actual,
loadConfig: () => config,
};
});
vi.mock("../../pairing/pairing-store.js", () => ({
readChannelAllowFromStore: (...args: unknown[]) => readAllowFromStoreMock(...args),
upsertChannelPairingRequest: (...args: unknown[]) => upsertPairingRequestMock(...args),
}));