fix(gateway): include deliveryContext in update.run restart sentinel (#18239)

This commit is contained in:
yinghaosang
2026-02-17 01:08:12 +08:00
committed by Peter Steinberger
parent d43c11c76d
commit aeec95f870
2 changed files with 138 additions and 0 deletions

View File

@@ -0,0 +1,134 @@
import { describe, expect, it, vi } from "vitest";
import type { RestartSentinelPayload } from "../../infra/restart-sentinel.js";
// Capture the sentinel payload written during update.run
let capturedPayload: RestartSentinelPayload | undefined;
vi.mock("../../config/config.js", () => ({
loadConfig: () => ({ update: {} }),
}));
vi.mock("../../config/sessions.js", () => ({
extractDeliveryInfo: (sessionKey: string | undefined) => {
if (!sessionKey) {
return { deliveryContext: undefined, threadId: undefined };
}
// Simulate a threaded Slack session
if (sessionKey.includes(":thread:")) {
return {
deliveryContext: { channel: "slack", to: "slack:C0123ABC", accountId: "workspace-1" },
threadId: "1234567890.123456",
};
}
return {
deliveryContext: { channel: "webchat", to: "webchat:user-123", accountId: "default" },
threadId: undefined,
};
},
}));
vi.mock("../../infra/openclaw-root.js", () => ({
resolveOpenClawPackageRoot: async () => "/tmp/openclaw",
}));
vi.mock("../../infra/restart-sentinel.js", async (importOriginal) => {
const actual = await importOriginal();
return {
...(actual as Record<string, unknown>),
writeRestartSentinel: async (payload: RestartSentinelPayload) => {
capturedPayload = payload;
return "/tmp/sentinel.json";
},
};
});
vi.mock("../../infra/restart.js", () => ({
scheduleGatewaySigusr1Restart: () => ({ scheduled: true }),
}));
vi.mock("../../infra/update-channels.js", () => ({
normalizeUpdateChannel: () => undefined,
}));
vi.mock("../../infra/update-runner.js", () => ({
runGatewayUpdate: async () => ({
status: "ok",
mode: "npm",
steps: [],
durationMs: 100,
}),
}));
vi.mock("../protocol/index.js", () => ({
validateUpdateRunParams: () => true,
}));
vi.mock("./restart-request.js", () => ({
parseRestartRequestParams: (params: Record<string, unknown>) => ({
sessionKey: params.sessionKey,
note: params.note,
restartDelayMs: undefined,
}),
}));
vi.mock("./validation.js", () => ({
assertValidParams: () => true,
}));
describe("update.run sentinel deliveryContext", () => {
it("includes deliveryContext in sentinel payload when sessionKey is provided", async () => {
capturedPayload = undefined;
const { updateHandlers } = await import("./update.js");
const handler = updateHandlers["update.run"];
let responded = false;
await handler({
params: { sessionKey: "agent:main:webchat:dm:user-123" },
respond: () => {
responded = true;
},
} as never);
expect(responded).toBe(true);
expect(capturedPayload).toBeDefined();
expect(capturedPayload!.deliveryContext).toEqual({
channel: "webchat",
to: "webchat:user-123",
accountId: "default",
});
});
it("omits deliveryContext when no sessionKey is provided", async () => {
capturedPayload = undefined;
const { updateHandlers } = await import("./update.js");
const handler = updateHandlers["update.run"];
await handler({
params: {},
respond: () => {},
} as never);
expect(capturedPayload).toBeDefined();
expect(capturedPayload!.deliveryContext).toBeUndefined();
expect(capturedPayload!.threadId).toBeUndefined();
});
it("includes threadId in sentinel payload for threaded sessions", async () => {
capturedPayload = undefined;
const { updateHandlers } = await import("./update.js");
const handler = updateHandlers["update.run"];
await handler({
params: { sessionKey: "agent:main:slack:dm:C0123ABC:thread:1234567890.123456" },
respond: () => {},
} as never);
expect(capturedPayload).toBeDefined();
expect(capturedPayload!.deliveryContext).toEqual({
channel: "slack",
to: "slack:C0123ABC",
accountId: "workspace-1",
});
expect(capturedPayload!.threadId).toBe("1234567890.123456");
});
});

View File

@@ -1,5 +1,6 @@
import type { GatewayRequestHandlers } from "./types.js";
import { loadConfig } from "../../config/config.js";
import { extractDeliveryInfo } from "../../config/sessions.js";
import { resolveOpenClawPackageRoot } from "../../infra/openclaw-root.js";
import {
formatDoctorNonInteractiveHint,
@@ -19,6 +20,7 @@ export const updateHandlers: GatewayRequestHandlers = {
return;
}
const { sessionKey, note, restartDelayMs } = parseRestartRequestParams(params);
const { deliveryContext, threadId } = extractDeliveryInfo(sessionKey);
const timeoutMsRaw = (params as { timeoutMs?: unknown }).timeoutMs;
const timeoutMs =
typeof timeoutMsRaw === "number" && Number.isFinite(timeoutMsRaw)
@@ -56,6 +58,8 @@ export const updateHandlers: GatewayRequestHandlers = {
status: result.status,
ts: Date.now(),
sessionKey,
deliveryContext,
threadId,
message: note ?? null,
doctorHint: formatDoctorNonInteractiveHint(),
stats: {